From 8b613a9f0f81a48ecfb32243c0a4c67e3fd48366 Mon Sep 17 00:00:00 2001 From: Jorijn van der Graaf Date: Sun, 1 Mar 2026 20:17:50 +0100 Subject: [PATCH] windows build fix --- implementations/Crafter.Build-Configuration.cpp | 3 ++- implementations/Crafter.Build-Project.cpp | 4 ++-- project.json | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/implementations/Crafter.Build-Configuration.cpp b/implementations/Crafter.Build-Configuration.cpp index 397e790..9fb1d5d 100644 --- a/implementations/Crafter.Build-Configuration.cpp +++ b/implementations/Crafter.Build-Configuration.cpp @@ -75,7 +75,8 @@ namespace Crafter { #endif #if defined(CRAFTER_BUILD_CONFIGURATION_TARGET_x86_64_pc_windows_msvc) || defined(CRAFTER_BUILD_CONFIGURATION_TARGET_x86_64_w64_mingw32) AutoDetect(); - target = RunCommand(std::format("{} && clang-cl.exe -print-target-triple", vsVars)); + target = "x86_64-pc-windows-msvc"; + //target = RunCommand(std::format("{} && clang-cl.exe -print-target-triple", vsVars)); #endif target.pop_back(); } diff --git a/implementations/Crafter.Build-Project.cpp b/implementations/Crafter.Build-Project.cpp index 13ca7e3..608fa01 100644 --- a/implementations/Crafter.Build-Project.cpp +++ b/implementations/Crafter.Build-Project.cpp @@ -473,11 +473,11 @@ namespace Crafter { #endif } else if(config.type == CRAFTER_CONFIGURATION_TYPE_LIBRARY) { #ifdef CRAFTER_BUILD_CONFIGURATION_TARGET_x86_64_pc_linux_gnu - RunCommandIgnore(std::format("ar r {}.a {}", (binDir/fs::path(std::string("lib")+outputName)).string(), files)); + RunClang(std::format("ar r {}.a {}", (binDir/fs::path(std::string("lib")+outputName)).string(), files)); #endif #if defined(CRAFTER_BUILD_CONFIGURATION_TARGET_x86_64_pc_windows_msvc) || defined(CRAFTER_BUILD_CONFIGURATION_TARGET_x86_64_w64_mingw32) - RunCommandIgnore(std::format("{} && lib.exe {} /OUT:{}.lib", vsVars, files, (binDir/fs::path(outputName)).string())); + RunClang(std::format("{} && lib.exe {} /OUT:{}.lib", vsVars, files, (binDir/fs::path(outputName)).string())); #endif } else { #ifdef CRAFTER_BUILD_CONFIGURATION_TARGET_x86_64_pc_linux_gnu diff --git a/project.json b/project.json index b553389..cbc7bf9 100644 --- a/project.json +++ b/project.json @@ -63,6 +63,7 @@ "extends": ["base", "libs-windows-msvc-debug"], "type":"library", "implementations": ["implementations/main"], + "lib_dirs": ["C:\\VulkanSDK\\1.4.341.1\\Lib"], "debug": true } ]