Catcrafts/Crafter.Build
2
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Merge pull request 'perf: build external cmake deps in parallel' (#21) from claude/issue-20 into master
All checks were successful
CI / build-test-release (push) Successful in 13m7s
Details

Browse source 
Reviewed-on: #21
This commit is contained in:
jorijnvdgraaf 2026-06-02 01:23:39 +02:00
commit b83170ffc8
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
implementations/Crafter.Build-External.cpp
View file

@ -210,7 +210,13 @@ std::string ConfigureCMake(const fs::path& cloneDir, const fs::path& cmakeBuildD
} }
std::string BuildCMake(const fs::path& cmakeBuildDir) { std::string BuildCMake(const fs::path& cmakeBuildDir) {
std::string cmd = std::format("cmake --build {}", ShellQuote(fs::absolute(cmakeBuildDir).string())); // Without --parallel, the Unix Makefiles generator builds one translation
// unit at a time, leaving every core but one idle. Pass an explicit job
// count (a bare --parallel maps to an unbounded `make -j` fork bomb on the
// Makefiles generator) so deps like DPP/msquic/glslang compile ~N× faster.
unsigned jobs = std::max(1u, std::thread::hardware_concurrency());
std::string cmd = std::format("cmake --build {} --parallel {}",
ShellQuote(fs::absolute(cmakeBuildDir).string()), jobs);
CommandResult r = RunCommandChecked(cmd); CommandResult r = RunCommandChecked(cmd);
if (r.exitCode != 0) { if (r.exitCode != 0) {
return std::format("cmake --build failed (exit {}): {}", r.exitCode, r.output); return std::format("cmake --build failed (exit {}): {}", r.exitCode, r.output);