Catcrafts/Crafter.Build
2
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Compare commits

base: Catcrafts:22fbef4ae1f553df0d7a9abb7dce20ca57e69e54
Branches Tags
Catcrafts:master
Catcrafts:latest
..
compare: Catcrafts:b83170ffc860f91d23050992355a4319ce8d41b9
Branches Tags
Catcrafts:master
Catcrafts:latest

2 commits
22fbef4ae1 ... b83170ffc8

Author SHA1 Message Date
jorijnvdgraaf
b83170ffc8 Merge pull request 'perf: build external cmake deps in parallel' (#21) from claude/issue-20 into master
All checks were successful
CI / build-test-release (push) Successful in 13m7s
Details 
Reviewed-on: #21
 2026-06-02 01:23:39 +02:00
catbot
06cccc3921 perf: build external cmake deps in parallel
All checks were successful
CI / build-test-release (pull_request) Successful in 9m0s
Details 
cmake --build was invoked with no --parallel, so the default Unix
Makefiles generator compiled external deps (DPP, msquic, glslang, …)
one translation unit at a time, leaving all but one core idle.

Pass an explicit --parallel N using hardware_concurrency() so dep
builds use the available cores. An explicit count (not a bare
--parallel) avoids an unbounded make -j fork bomb on the Makefiles
generator.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-06-01 20:38:00 +00:00
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
implementations/Crafter.Build-External.cpp
View file

@ -210,7 +210,13 @@ std::string ConfigureCMake(const fs::path& cloneDir, const fs::path& cmakeBuildD
} }
std::string BuildCMake(const fs::path& cmakeBuildDir) { std::string BuildCMake(const fs::path& cmakeBuildDir) {
std::string cmd = std::format("cmake --build {}", ShellQuote(fs::absolute(cmakeBuildDir).string())); // Without --parallel, the Unix Makefiles generator builds one translation
// unit at a time, leaving every core but one idle. Pass an explicit job
// count (a bare --parallel maps to an unbounded `make -j` fork bomb on the
// Makefiles generator) so deps like DPP/msquic/glslang compile ~N× faster.
unsigned jobs = std::max(1u, std::thread::hardware_concurrency());
std::string cmd = std::format("cmake --build {} --parallel {}",
ShellQuote(fs::absolute(cmakeBuildDir).string()), jobs);
CommandResult r = RunCommandChecked(cmd); CommandResult r = RunCommandChecked(cmd);
if (r.exitCode != 0) { if (r.exitCode != 0) {
return std::format("cmake --build failed (exit {}): {}", r.exitCode, r.output); return std::format("cmake --build failed (exit {}): {}", r.exitCode, r.output);