[perf] ReclaimDeletions compacts the whole deletion queue every frame (Device.cpp) #116

New issue

Closed

opened 2026-06-17 21:18:53 +02:00 by jorijnvdgraaf · 0 comments

jorijnvdgraaf commented

2026-06-17 21:18:53 +02:00

Owner

Found by an adversarially-verified performance audit (confirmed real after a skeptic pass).

Location: implementations/Crafter.Graphics-Device.cpp:1012-1028
Severity: low · Effort: moderate · Category: cpu

Problem

ReclaimDeletions is called once per frame (Window.cpp:802) and does an O(n) walk + survivor copy over the whole deletion queue. retireAfter is monotonic, so the ready entries are always a prefix.

Fix

Ring buffer / deque::pop_front while the front is retired → O(ready). Minor in practice: the queue is empty in steady state and entries are 24 B contiguous.

Found by an adversarially-verified performance audit (confirmed real after a skeptic pass). **Location:** `implementations/Crafter.Graphics-Device.cpp:1012-1028` **Severity:** low · **Effort:** moderate · **Category:** cpu ### Problem `ReclaimDeletions` is called once per frame (`Window.cpp:802`) and does an O(n) walk + survivor copy over the whole deletion queue. `retireAfter` is monotonic, so the ready entries are always a prefix. ### Fix Ring buffer / `deque::pop_front` while the front is retired → O(ready). Minor in practice: the queue is empty in steady state and entries are 24 B contiguous.

jorijnvdgraaf added the

claude:ready

label

2026-06-17 21:23:42 +02:00