[perf][LOW] Descriptor-heap bind recorded unconditionally every frame #42

New issue

Closed

opened 2026-06-16 16:51:30 +02:00 by jorijnvdgraaf · 0 comments

jorijnvdgraaf commented

2026-06-16 16:51:30 +02:00

Owner

Subsystem: Window / swapchain / frame loop
Location: implementations/Crafter.Graphics-Window.cpp:736-758
Impact: LOW · Effort: Small

Problem

Every frame rebuilds two VkBindHeapInfoEXT structs and recomputes reservedRangeOffset via a runtime subtract + bitmask against Device::descriptorHeapProperties. The heap address/size per slot are stable; only currentBuffer varies.

Proposed fix

Precompute numFrames VkBindHeapInfoEXT structs when the heap is assigned / swapchain recreated, and record the cached struct for currentBuffer.

Correctness caveat

Invalidate the cache from the descriptorHeap setter (the safest hook), not onResize. The heaps never resize today, so this is correct.

**Subsystem:** Window / swapchain / frame loop **Location:** `implementations/Crafter.Graphics-Window.cpp:736-758` **Impact:** LOW · **Effort:** Small ### Problem Every frame rebuilds two `VkBindHeapInfoEXT` structs and recomputes `reservedRangeOffset` via a runtime subtract + bitmask against `Device::descriptorHeapProperties`. The heap address/size per slot are stable; only `currentBuffer` varies. ### Proposed fix Precompute `numFrames` `VkBindHeapInfoEXT` structs when the heap is assigned / swapchain recreated, and record the cached struct for `currentBuffer`. ### Correctness caveat Invalidate the cache from the `descriptorHeap` **setter** (the safest hook), not `onResize`. The heaps never resize today, so this is correct.

jorijnvdgraaf added the

claude:ready

label

2026-06-16 17:16:04 +02:00