[perf][LOW] Compressed-asset Update re-Resizes both staging buffers every call #71

New issue

Closed

opened 2026-06-16 16:51:35 +02:00 by jorijnvdgraaf · 0 comments

jorijnvdgraaf commented

2026-06-16 16:51:35 +02:00

Owner

Subsystem: Image pipeline (compressed assets)
Location: interfaces/Crafter.Graphics-ImageVulkan.cppm:186-205
Impact: Low · Effort: Small · Not hot path (each caller invokes once at setup)

Problem

Compressed-asset Update re-Resizes both staging buffers every call. Every shipped caller invokes it once at setup; the streaming scenario is hypothetical.

Proposed fix

Grow-only reuse.

Correctness caveat

Must keep the MEMORY_DECOMPRESSION flag gated on Device::memoryDecompressionSupported, and does not by itself make streaming safe (still needs fence/double-buffer).

**Subsystem:** Image pipeline (compressed assets) **Location:** `interfaces/Crafter.Graphics-ImageVulkan.cppm:186-205` **Impact:** Low · **Effort:** Small · Not hot path (each caller invokes once at setup) ### Problem Compressed-asset `Update` re-Resizes both staging buffers every call. Every shipped caller invokes it **once** at setup; the streaming scenario is hypothetical. ### Proposed fix Grow-only reuse. ### Correctness caveat Must keep the `MEMORY_DECOMPRESSION` flag gated on `Device::memoryDecompressionSupported`, and does not by itself make streaming safe (still needs fence/double-buffer).

jorijnvdgraaf closed this issue

2026-06-17 19:29:18 +02:00