From 7d932892017800b4e1f1a15fe7aa49b3daee9ceb Mon Sep 17 00:00:00 2001 From: Jorijn van der Graaf Date: Sat, 31 Oct 2026 02:44:46 +0100 Subject: [PATCH] fix: drop the depArgs reference the lite rework left behind 42a2701 removed the depArgs declaration together with the --local branch it fed, but the GitProject call that remained still passed .args = depArgs. project.cpp stopped compiling, and with it every load of this repository: crafter-build's own project.cpp pulls it in through #pragma crafter dependency, so its build, lint and test runs fail as soon as the clone is updated. The call now passes no args. The test's crafter-build dependency only needs the host defaults, and crafter-build is about to forward a project's own args to its sibling projects by default anyway. The comment above it still described the --local checkout the same commit removed; it now says what the code does. Co-Authored-By: Claude Opus 5.5 --- project.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/project.cpp b/project.cpp index 11da1ec..0deb5c8 100644 --- a/project.cpp +++ b/project.cpp @@ -24,8 +24,7 @@ extern "C" Configuration CrafterBuildProject(std::span a cfg.GetInterfacesAndImplementations(ifaces, impls); // The rule test compiles the module as its own interface and links - // crafter-build to run the linter in-process: from git by default, or - // the sibling checkout with `crafter-build test --local`. Only when this + // crafter-build, from git, to run the linter in-process. Only when this // is the project being built: crafter-build itself loads this file as a // dependency, and the test's GitProject would then load crafter-build's // project file again and recurse into the cycle guard. No target check: @@ -33,7 +32,7 @@ extern "C" Configuration CrafterBuildProject(std::span a // to compare against silently dropped the test on any host that spells // its triple differently (the Flatpak's x86_64-unknown-linux-gnu). if (IsTopLevelProject()) { - Configuration* build = GitProject({ .source = { .url = "https://forgejo.catcrafts.net/Catcrafts/Crafter.Build.git" }, .args = depArgs }); + Configuration* build = GitProject({ .source = { .url = "https://forgejo.catcrafts.net/Catcrafts/Crafter.Build.git" } }); cfg.AddTest("HouseRules", ifaces).Dependencies({ build }); } return cfg;