Crafter.Review/tests/Goldens/fixture/code-keys/context/0002-greet-by-name-and-document-it.patch

55 lines
1.3 KiB
Diff
Raw Permalink Normal View History

feat(pipeline): the pure pipeline, checked against its goldens The modules that turn a frozen range into passes and passes into a verdict: :Schema, :Tools (the DENY, git and base lists, a leaf, so the config and the pool both read them), :Plan, :Artifact, :Inventory, :Dispositions, :State, :Normalize, :Stream, :Prompt, :Config, and the URL half of :PgWire. Units, jobs, results, the config and the claude stream stay JSON from end to end, so every key keeps its place; :Text gives JSON values truthiness, get, ==, membership and Str(), and throws Dyn::Error under a name for each kind of unexpected data. Exactness where the bytes are seen: - the stream classifiers are hand-written scanners with case-insensitive folds (the Kelvin sign is a k), Unicode \b and \s, and `.` stopping at \n; the SQL call detection takes `<exe> sql` with any path before it; - config problems carry the JSON scanner's and the UTF-8 decoder's own texts, positions included; - a float total is Neumaier's compensated sum, and the build passes -ffp-contract=off: -march=native would fuse a*b+c; - `crafter-review inventory` and `config` print what the goldens record, byte for byte (the fixture and 14 configs, broken ones included); a message names this binary as the command to run. tests/Goldens: the recorded answers over the fixtures next to them (the commits fixture, a rich versioned series with CRLF, a folded subject, Markdown headings in and out of fences, the code-key rewrites); the suite compares 2304 results as DumpFile writes them, so a key out of order fails too. All agree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 06:48:55 +01:00
From 2222222222222222222222222222222222222222 Mon Sep 17 00:00:00 2001
From: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
Date: Wed, 24 Sep 2026 10:05:00 +0200
Subject: [PATCH 2/2] greet by name and document it
The greeting takes a name now and the farewell mirrors it; the README
documents both calls. Callers that pass nothing still get the old text.
The format follows the greeting spec [1].
[1] https://example.org/greeting-spec
---
README.md | 4 ++++
hello.py | 8 ++++++--
2 files changed, 10 insertions(+), 2 deletions(-)
create mode 100644 README.md
diff --git a/README.md b/README.md
new file mode 100644
index 0000000..d4e5f6a
--- /dev/null
+++ b/README.md
@@ -0,0 +1,4 @@
+# hello
+
+Call `greet(name)` or `farewell(name)`; without a name both return the
+plain text.
diff --git a/hello.py b/hello.py
index a1b2c3d..b7c8d9e 100644
--- a/hello.py
+++ b/hello.py
@@ -1,9 +1,13 @@
"""Greetings, by name."""
-def greet():
- return "hello"
+def greet(name=None):
+ if name is None:
+ return "hello"
+ return "hello " + name
@@ -7,3 +11,5 @@ def greet():
-def farewell():
- return "bye"
+def farewell(name=None):
+ if name is None:
+ return "bye"
+ return "bye " + name
base-commit: 0000000000000000000000000000000000000000
--
2.51.0