Catcrafts/Crafter.Review
Watch
2
0
Fork
You've already forked Crafter.Review
 0
Code Issues 7 Pull requests Projects Releases 3 Packages Wiki Activity Actions

feat(modes): the kernel modes - a patch series and a mailing-list reply

Browse source 
Beside the push gates, crafter-review runs the pre-send review of a kernel
contributor's workbench: --mode series over a format-patch export with its
cover letter, --mode reply over a mail draft. The inventory partitions a
cover letter, a plain mail and the camera review's shape; ten kernel lenses
join the table with their gates (structure, code, artifact truth) and the
persona gate - one maintainer-persona instance per --reviewers entry, its
whole pass gating its blocks and pruning the units that are not theirs. A
series' code units are keyed on the code like the push gates'; every text
unit on its text, the references it cites and the anchor when it is dated.
The references an artifact cites are prefetched through utilities/lore.py
into the gate-state, with a digest in the run layer, and a persona's
calibration map is its lore listing. The kernel schema carries the persona
vocabulary, the kernel note kinds, the predicted review and the not-mine
list; the matrix the persona holes, the thin and the modelled units; gates
clean without a persona pass is GATES CLEAN. A reply's gate-state sits
beside the draft and is read once; a kernel mode needs --subsystem,
defaults the effort to max and the trees to work/linux,work/milos-linux,
and excuses no unit from the holes.

The kernel lenses and the common text ship verbatim; the table lists them
after the push gates' lenses and the config template holds them off, so a
repository that never turns them on changes nothing. Prompts, keys and plans
were checked byte for byte against the pipeline these modes replace, on its
own artifacts: two replies and a series, every system prompt, user prompt,
job and reuse key identical.
This commit is contained in:
Jorijn van der Graaf 2026-10-31 22:56:12 +01:00
commit 339f4b9b40
Signed by: jorijnvdgraaf
GPG key ID: 2937E59CDCC1BCFB
46 changed files with 5732 additions and 362 deletions
Download patch file Download diff file Expand all files Collapse all files

10
implementations/Crafter.Review-Pool.cpp
View file

@ -161,9 +161,17 @@ namespace Crafter::Review::Pool {
return std::format("{}://{}:{}{}", p.scheme, host, portText, p.path);
}
std::vector<std::string> AllowedTools(std::string_view, std::string_view, std::span<const std::string> trees, std::span<const std::string> extra,
std::vector<std::string> AllowedTools(std::string_view lensFile, std::string_view, std::span<const std::string> trees, std::span<const std::string> extra,
const std::optional<std::string>& loginFixture, std::string_view environment) {
std::vector<std::string> allow = Tools::BaseAllow();
// The kernel lenses read lore through the helper: every one fetches;
// the lenses that judge against the list search too (2026-09-17: a
// facts block without search reported a posted series as
// unfindable).
const bool kernel = Plan::IsLens(lensFile) && Plan::LensOf(lensFile).kernel;
if (kernel) allow.emplace_back("Bash(python3 utilities/lore.py fetch:*)");
constexpr std::array<std::string_view, 6> LoreSearch = {"facts.md", "consistency.md", "etiquette.md", "process-docs.md", "better-solution.md", Plan::PersonaLens};
if (std::ranges::contains(LoreSearch, lensFile)) allow.emplace_back("Bash(python3 utilities/lore.py search:*)");
const std::string cwd = fs::current_path().string();
for (const std::string& t : trees) {
// Both spellings: lenses write absolute -C paths too (sabotage