feat(modes): the kernel modes - a patch series and a mailing-list reply
Beside the push gates, crafter-review runs the pre-send review of a kernel contributor's workbench: --mode series over a format-patch export with its cover letter, --mode reply over a mail draft. The inventory partitions a cover letter, a plain mail and the camera review's shape; ten kernel lenses join the table with their gates (structure, code, artifact truth) and the persona gate - one maintainer-persona instance per --reviewers entry, its whole pass gating its blocks and pruning the units that are not theirs. A series' code units are keyed on the code like the push gates'; every text unit on its text, the references it cites and the anchor when it is dated. The references an artifact cites are prefetched through utilities/lore.py into the gate-state, with a digest in the run layer, and a persona's calibration map is its lore listing. The kernel schema carries the persona vocabulary, the kernel note kinds, the predicted review and the not-mine list; the matrix the persona holes, the thin and the modelled units; gates clean without a persona pass is GATES CLEAN. A reply's gate-state sits beside the draft and is read once; a kernel mode needs --subsystem, defaults the effort to max and the trees to work/linux,work/milos-linux, and excuses no unit from the holes. The kernel lenses and the common text ship verbatim; the table lists them after the push gates' lenses and the config template holds them off, so a repository that never turns them on changes nothing. Prompts, keys and plans were checked byte for byte against the pipeline these modes replace, on its own artifacts: two replies and a series, every system prompt, user prompt, job and reuse key identical.
This commit is contained in:
parent
4fc15fe1c2
commit
339f4b9b40
46 changed files with 5732 additions and 362 deletions
44
tests/KernelModes/fixture/draft-camera.txt
Normal file
44
tests/KernelModes/fixture/draft-camera.txt
Normal file
|
|
@ -0,0 +1,44 @@
|
|||
Hallo Thomas,
|
||||
|
||||
Dank je voor de nieuwe versie.
|
||||
|
||||
ov13b10-of/0001-media-i2c-ov13b10.patch
|
||||
|
||||
De eerste patch ziet er goed uit; zie punt 1 hieronder.
|
||||
|
||||
ov13b10-of/0000-cover-letter.patch
|
||||
|
||||
De cover noemt de test op 2026-09-10; dat klopt met wat ik zag.
|
||||
|
||||
Dates: every "still", "unmerged", "in review" and "latest version" below is
|
||||
as of 2026-09-21 (work/linux at v7.1-rc2, work/milos-linux at v7.1.2-milos).
|
||||
|
||||
Reversals of the 2026-08-18 review (two points where that review was wrong):
|
||||
|
||||
R1. The active-array origin (ov13b10 3/3). The 08-18 review said the origin
|
||||
was (0, 0); the datasheet [1] gives (8, 8), so the earlier ask is withdrawn.
|
||||
|
||||
R2. The link-frequencies constraint (ov13b10 1/3) depends on R1 and on the
|
||||
binding example in [2]; it is still open as of 2026-09-21.
|
||||
|
||||
camss-milos
|
||||
|
||||
1. num_clients (camss 2/5). The field is read once; the v3 series on the
|
||||
list [1] does the same.
|
||||
a. The error path leaves the clock enabled.
|
||||
b. The comment above it names the wrong register.
|
||||
|
||||
2. Required supplies (camss 1/5). Matches the binding in [2].
|
||||
|
||||
ov13b10-of
|
||||
|
||||
1. The crop default. A plain paragraph item without a citation at all.
|
||||
|
||||
across the three series
|
||||
|
||||
- Every series cites the same datasheet; the three cover letters should
|
||||
agree on its revision.
|
||||
- The Cc lists differ between the series.
|
||||
|
||||
[1] https://lore.kernel.org/r/7927bdab-9c3b-460d-a2ba-2e5b06ee8804@kernel.org/
|
||||
[2] https://lore.kernel.org/all/20260815.4567@example.org/
|
||||
22
tests/KernelModes/fixture/reply.eml
Normal file
22
tests/KernelModes/fixture/reply.eml
Normal file
|
|
@ -0,0 +1,22 @@
|
|||
From: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
|
||||
To: Some Maintainer <maintainer@example.org>
|
||||
Cc: linux-example@vger.kernel.org
|
||||
Subject: Re: [PATCH v2] nfc: widget: add the driver
|
||||
In-Reply-To: <20260920.111@example.org>
|
||||
References: <20260920.111@example.org>
|
||||
|
||||
On Sat, 20 Sep 2026 at 10:00, Some Maintainer wrote:
|
||||
> The probe should not read the revision twice.
|
||||
>
|
||||
> Please drop the second read.
|
||||
|
||||
Agreed, v3 reads it once and keeps it for the attribute.
|
||||
|
||||
> And the binding needs the example.
|
||||
|
||||
The example is in 2/2 of v3; it follows [1].
|
||||
|
||||
[1] https://lore.kernel.org/all/20260815.4567@example.org/
|
||||
|
||||
Tested-by: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
|
||||
Reviewed-by: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
|
||||
25
tests/KernelModes/fixture/series/0000-cover-letter.patch
Normal file
25
tests/KernelModes/fixture/series/0000-cover-letter.patch
Normal file
|
|
@ -0,0 +1,25 @@
|
|||
From 3333333333333333333333333333333333333333 Mon Sep 17 00:00:00 2001
|
||||
From: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
|
||||
Date: Thu, 25 Sep 2026 09:00:00 +0200
|
||||
Subject: [PATCH 0/2] nfc: widget: add the driver and its binding
|
||||
|
||||
This series adds the widget driver and documents its binding.
|
||||
|
||||
The driver was tested on the board described in [1]; the binding follows
|
||||
the example the maintainer asked for in the v1 review, which is still
|
||||
unmerged as of 2026-09-21.
|
||||
|
||||
[1] https://lore.kernel.org/all/20260901.1234@example.org/
|
||||
|
||||
Jorijn van der Graaf (2):
|
||||
nfc: widget: add the driver
|
||||
dt-bindings: nfc: document the widget
|
||||
|
||||
Documentation/devicetree/bindings/nfc/widget.yaml | 18 ++++++++++++++++++
|
||||
README.md | 3 +++
|
||||
drivers/nfc/widget.c | 12 ++++++++++++
|
||||
3 files changed, 33 insertions(+)
|
||||
|
||||
base-commit: 0000000000000000000000000000000000000000
|
||||
--
|
||||
2.51.0
|
||||
|
|
@ -0,0 +1,37 @@
|
|||
From 4444444444444444444444444444444444444444 Mon Sep 17 00:00:00 2001
|
||||
From: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
|
||||
Date: Thu, 25 Sep 2026 09:01:00 +0200
|
||||
Subject: [PATCH 1/2] nfc: widget: add the driver
|
||||
|
||||
The widget answers on I2C and reports its revision at probe. The probe
|
||||
reads the revision register once and keeps it for the sysfs attribute.
|
||||
|
||||
Tested on the board as of 2026-09-20 with v1 of the firmware.
|
||||
|
||||
Signed-off-by: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
|
||||
Reviewed-by: Some Reviewer <reviewer@example.org>
|
||||
---
|
||||
drivers/nfc/widget.c | 12 ++++++++++++
|
||||
1 file changed, 12 insertions(+)
|
||||
create mode 100644 drivers/nfc/widget.c
|
||||
|
||||
diff --git a/drivers/nfc/widget.c b/drivers/nfc/widget.c
|
||||
new file mode 100644
|
||||
index 0000000..a1b2c3d
|
||||
--- /dev/null
|
||||
+++ b/drivers/nfc/widget.c
|
||||
@@ -0,0 +1,12 @@
|
||||
+// SPDX-License-Identifier: GPL-2.0
|
||||
+#include <linux/i2c.h>
|
||||
+
|
||||
+static int widget_probe(struct i2c_client *client)
|
||||
+{
|
||||
+ int rev;
|
||||
+
|
||||
+ rev = i2c_smbus_read_byte_data(client, 0x00);
|
||||
+ if (rev < 0)
|
||||
+ return rev;
|
||||
+ return 0;
|
||||
+}
|
||||
--
|
||||
2.51.0
|
||||
|
|
@ -0,0 +1,51 @@
|
|||
From 5555555555555555555555555555555555555555 Mon Sep 17 00:00:00 2001
|
||||
From: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
|
||||
Date: Thu, 25 Sep 2026 09:02:00 +0200
|
||||
Subject: [PATCH 2/2] dt-bindings: nfc: document the widget
|
||||
|
||||
Document the widget's compatible and its one supply; the README gains a
|
||||
line about the binding.
|
||||
|
||||
Signed-off-by: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
|
||||
---
|
||||
Documentation/devicetree/bindings/nfc/widget.yaml | 18 ++++++++++++++++++
|
||||
README.md | 3 +++
|
||||
2 files changed, 21 insertions(+)
|
||||
create mode 100644 Documentation/devicetree/bindings/nfc/widget.yaml
|
||||
|
||||
diff --git a/Documentation/devicetree/bindings/nfc/widget.yaml b/Documentation/devicetree/bindings/nfc/widget.yaml
|
||||
new file mode 100644
|
||||
index 0000000..c3d4e5f
|
||||
--- /dev/null
|
||||
+++ b/Documentation/devicetree/bindings/nfc/widget.yaml
|
||||
@@ -0,0 +1,18 @@
|
||||
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
|
||||
+%YAML 1.2
|
||||
+---
|
||||
+$id: http://devicetree.org/schemas/nfc/widget.yaml#
|
||||
+$schema: http://devicetree.org/meta-schemas/core.yaml#
|
||||
+
|
||||
+title: Widget NFC controller
|
||||
+
|
||||
+properties:
|
||||
+ compatible:
|
||||
+ const: example,widget
|
||||
+ vdd-supply: true
|
||||
+
|
||||
+required:
|
||||
+ - compatible
|
||||
+ - vdd-supply
|
||||
+
|
||||
+additionalProperties: false
|
||||
diff --git a/README.md b/README.md
|
||||
index d4e5f6a..e5f6a7b 100644
|
||||
--- a/README.md
|
||||
+++ b/README.md
|
||||
@@ -1,2 +1,5 @@
|
||||
# hello
|
||||
|
||||
+The widget binding lives under Documentation/devicetree/bindings/nfc/.
|
||||
+It names one supply.
|
||||
+
|
||||
--
|
||||
2.51.0
|
||||
Loading…
Reference in a new issue