Catcrafts/Crafter.Review
Watch
2
0
Fork
You've already forked Crafter.Review
 0
Code Issues 7 Pull requests Projects Releases 3 Packages Wiki Activity Actions

feat(config): lens sections - a repository's own text appended to a shipped charter

Browse source 
A lens has one charter, the one this pipeline ships; what a repository
knows that is not general to the lens - its platform and layers, the
record it keeps its decisions in, what its users already have, the
calibration entries that are its own - goes in a file the config names
for the lens (lenses.<name>.section), and Charter appends it after one
blank line. The charter sha in every reuse key covers the combined text.

The config refuses a path outside the repository - absolute, or
climbing out with `..` - by the check slots.dir had, now one both
settings share; a file missing or one the run could not use (a dangling
link, unreadable, not UTF-8) is a problem too, checked through the
reader Charter uses (Prompt::ReadSection), so a section is never
dropped in silence, and a name that is no lens is the unknown key it
always was. Nothing lists a directory, so what lies beside the files is
no concern of the config's: a directory listed would have to tolerate or
refuse every foreign entry. The run logs which charters got one.

The better-solution charter gains a consumer's general entry
(2026-10-31: a mechanism reworked a second time in one submission is the
signal to derive the fix at every layer the data crosses). The procedure
names the section wherever it names the charter: among the config's keys,
in the lens inputs, in the reuse rule (an edit to either re-runs the lens)
and in the feedback loop, which routes a repository's own lesson to its
section and a general one to the shipped charter.
This commit is contained in:
Jorijn van der Graaf 2026-11-01 01:30:22 +01:00
commit 6cf15919db
Signed by: jorijnvdgraaf
GPG key ID: 2937E59CDCC1BCFB
16 changed files with 1235 additions and 524 deletions
Download patch file Download diff file Expand all files Collapse all files

13
implementations/Crafter.Review-Run.cpp
View file

@ -615,6 +615,19 @@ namespace Crafter::Review::Run {
log(std::format("reads: every code unit of the {}code lenses needs {} clean reads, one per round; this is round {} on this hash{}", Kernel() ? "" : "static ", x, round,
newRound || !sameHash ? std::string() : std::string(" (continuing an unfinished run)")));
}
// The repository's own lens sections (lenses.<name>.section): each
// file is appended to its lens's shipped charter (Prompt::Charter), so
// the charter sha in every reuse key covers it. The config refused a
// path outside the repository and a file the run could not read.
const std::map<std::string, fs::path> sections = Config::LensSectionsOf(cfg, repo);
Prompt::SetLensSections(sections);
if (!sections.empty()) {
std::vector<std::string> own;
for (const std::string& lf : modeLenses) {
if (sections.contains(lf)) own.push_back(Plan::LensName(lf));
}
log(std::format("lenses: the repository's sections appended to {}", own.empty() ? std::string("no charter of this mode") : Dyn::Join(own, ", ")));
}
for (const Plan::Lens& lens : Plan::Lenses) {
const std::string lf(lens.file);
charters[lf] = Prompt::Charter(lf);