feat(pipeline): the pure pipeline, checked against its goldens
The modules that turn a frozen range into passes and passes into a verdict: :Schema, :Tools (the DENY, git and base lists, a leaf, so the config and the pool both read them), :Plan, :Artifact, :Inventory, :Dispositions, :State, :Normalize, :Stream, :Prompt, :Config, and the URL half of :PgWire. Units, jobs, results, the config and the claude stream stay JSON from end to end, so every key keeps its place; :Text gives JSON values truthiness, get, ==, membership and Str(), and throws Dyn::Error under a name for each kind of unexpected data. Exactness where the bytes are seen: - the stream classifiers are hand-written scanners with case-insensitive folds (the Kelvin sign is a k), Unicode \b and \s, and `.` stopping at \n; the SQL call detection takes `<exe> sql` with any path before it; - config problems carry the JSON scanner's and the UTF-8 decoder's own texts, positions included; - a float total is Neumaier's compensated sum, and the build passes -ffp-contract=off: -march=native would fuse a*b+c; - `crafter-review inventory` and `config` print what the goldens record, byte for byte (the fixture and 14 configs, broken ones included); a message names this binary as the command to run. tests/Goldens: the recorded answers over the fixtures next to them (the commits fixture, a rich versioned series with CRLF, a folded subject, Markdown headings in and out of fences, the code-key rewrites); the suite compares 2304 results as DumpFile writes them, so a key out of order fails too. All agree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
b02de3ceff
commit
741e3a656d
70 changed files with 30565 additions and 21 deletions
32
interfaces/Crafter.Review-Schema.cppm
Normal file
32
interfaces/Crafter.Review-Schema.cppm
Normal file
|
|
@ -0,0 +1,32 @@
|
|||
// SPDX-License-Identifier: AGPL-3.0-only
|
||||
// SPDX-FileCopyrightText: Copyright (C) 2026 Catcrafts®
|
||||
|
||||
export module Crafter.Review:Schema;
|
||||
import std;
|
||||
import :Json;
|
||||
|
||||
// The structured output a pass returns: FINDING, NOTE, COVERAGE and the
|
||||
// verdict. One block schema and one whole schema per run, the union of every
|
||||
// lens's vocabulary, so the tool block ahead of the user message is
|
||||
// byte-identical across lenses and the prompt cache is shared. The bytes are
|
||||
// fixed: SchemaJson() is the schema in DumpCompactSorted's form, and the
|
||||
// goldens hold the descriptions.
|
||||
export namespace Crafter::Review::Schema {
|
||||
constexpr std::array<std::string_view, 10> NoteKinds = {
|
||||
"reserve-answer", "invariant", "pre-existing", "residual-risk", "hold", "info", "immaterial",
|
||||
"send-time-check", "refutation-verified", "unverified",
|
||||
};
|
||||
constexpr std::array<std::string_view, 4> CoverageVerdicts = {"clear", "defect", "immaterial", "n/a"};
|
||||
constexpr std::array<std::string_view, 1> CoverageBlocking = {"defect"};
|
||||
constexpr std::array<std::string_view, 2> CoverageUnowned = {"n/a", "MISSING"};
|
||||
constexpr std::array<std::string_view, 2> VerdictEnum = {"FIX FIRST", "SEND-READY"};
|
||||
|
||||
Json Finding();
|
||||
Json Note();
|
||||
Json Coverage();
|
||||
Json BlockSchema();
|
||||
Json WholeSchema();
|
||||
// The schema of `kind` ("block", anything else the whole one) as it goes
|
||||
// to claude.
|
||||
std::string SchemaJson(std::string_view kind);
|
||||
}
|
||||
Loading…
Reference in a new issue