Ledger::Save is public, unused and overwrites the shared ledger #4

New issue

Open

opened 2026-11-02 18:34:14 +00:00 by jorijnvdgraaf · 0 comments

jorijnvdgraaf commented

2026-11-02 18:34:14 +00:00

Owner

Ledger::Save writes this process's whole copy of seat-ledger.json over the file. That is the last-writer-wins write Ledger::Update replaced on 2026-10-15, when one driver's save erased spend another had recorded. Nothing calls Save, at master or in 1.1.0, but it is still public, so a future caller would bring the lost update back.

A fix removes it.

Found by the 1.1.0 push gates.

`Ledger::Save` writes this process's whole copy of `seat-ledger.json` over the file. That is the last-writer-wins write `Ledger::Update` replaced on 2026-10-15, when one driver's save erased spend another had recorded. Nothing calls `Save`, at master or in 1.1.0, but it is still public, so a future caller would bring the lost update back. A fix removes it. Found by the 1.1.0 push gates.