run --scratch keeps a seat ledger that seats never reads #5
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Catcrafts/Crafter.Review#5
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
runkeeps the seat ledger under its scratch root (LedgerPath(scratchRoot), sorun --scratch XusesX/seat-ledger.json), whileseatsalways usesLedgerPath()($REVIEW_GATES_SCRATCH, else~/.cache/review-gates). With--scratchthe two keep separate ledgers: what such a run spends is not whatseatsshows, and from 1.1.0 the grants and credit errorsseatsrecords never reach that run.A fix gives both one ledger: a
--scratchoption forseats, or a ledger path that does not follow--scratch.Found by the 1.1.0 push gates.