run --scratch keeps a seat ledger that seats never reads #5

Open
opened 2026-11-02 18:34:14 +00:00 by jorijnvdgraaf · 0 comments

run keeps the seat ledger under its scratch root (LedgerPath(scratchRoot), so run --scratch X uses X/seat-ledger.json), while seats always uses LedgerPath() ($REVIEW_GATES_SCRATCH, else ~/.cache/review-gates). With --scratch the two keep separate ledgers: what such a run spends is not what seats shows, and from 1.1.0 the grants and credit errors seats records never reach that run.

A fix gives both one ledger: a --scratch option for seats, or a ledger path that does not follow --scratch.

Found by the 1.1.0 push gates.

`run` keeps the seat ledger under its scratch root (`LedgerPath(scratchRoot)`, so `run --scratch X` uses `X/seat-ledger.json`), while `seats` always uses `LedgerPath()` (`$REVIEW_GATES_SCRATCH`, else `~/.cache/review-gates`). With `--scratch` the two keep separate ledgers: what such a run spends is not what `seats` shows, and from 1.1.0 the grants and credit errors `seats` records never reach that run. A fix gives both one ledger: a `--scratch` option for `seats`, or a ledger path that does not follow `--scratch`. Found by the 1.1.0 push gates.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Catcrafts/Crafter.Review#5
No description provided.