Driver for extensive AI code reviews
  • C++ 99.5%
  • Python 0.4%
Find a file
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Jorijn van der Graaf 53b7d6de31
fix: three errors that ended with the wrong exit code
Found compiling the environment-variable table for AGENTS.md:
- A REVIEW_GATES_MEM_RESERVE_MB that is no number threw
  std::invalid_argument, which nothing caught: the process aborted where
  it should end with a ValueError, exit 1. nan and inf were an unchecked
  cast. They raise ValueError / OverflowError now; a value past int64
  saturates.
- An env file that is not UTF-8: `run` ended with exit 1 where its
  preflight should stop it (exit 3), and `seats` parsed the raw bytes. Both
  read it as strict UTF-8 text now.
- A broker address with a port past 65535 was cut to 16 bits; it is an
  OverflowError now, uncaught (exit 1).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 16:35:26 +01:00
.forgejo/workflows ci: the Flatpak workflow, local deps for the local build, the lens tools 2026-10-31 15:59:20 +01:00
implementations fix: three errors that ended with the wrong exit code 2026-10-31 16:35:26 +01:00
interfaces fix: three errors that ended with the wrong exit code 2026-10-31 16:35:26 +01:00
lib chore: vendor nlohmann/json 3.12.0, and the licence text 2026-10-31 05:29:18 +01:00
packaging/flatpak build(flatpak): net.catcrafts.CrafterReview on the Crafter.Build base 2026-10-31 06:01:19 +01:00
process feat(core): the data home, the lens texts, and --version naming both 2026-10-31 05:51:37 +01:00
tests fix: three errors that ended with the wrong exit code 2026-10-31 16:35:26 +01:00
.gitignore build(flatpak): net.catcrafts.CrafterReview on the Crafter.Build base 2026-10-31 06:01:19 +01:00
LICENSE chore: vendor nlohmann/json 3.12.0, and the licence text 2026-10-31 05:29:18 +01:00
project.cpp ci: the Flatpak workflow, local deps for the local build, the lens tools 2026-10-31 15:59:20 +01:00
README.md docs: the README 2026-10-31 16:18:42 +01:00

Crafter Review

The pre-push review pipeline: adversarial lenses review a frozen commit range, one claude --print process per inventory unit, before the range is pushed. Four lenses in a fixed order: the approach, the range exercised in the running application through the Playwright MCP server, and side by side the static bug proof and the security review. The repository's config says which of them run and what each gets: the browser, the local Supabase database, both, or neither.

Gate Lens Question
1 repo-better-solution (a whole pass gating code blocks) the right mechanism, layer and commit shape? compatible with what users have?
2 repo-functional (a whole pass gating code blocks; the browser or browser+supabase environment) in the running application, does the range do what its code and messages say, and does it leave the flows next to it working?
3 repo-bug-prover (code blocks, static; with the database a proof may also run there) a demonstrated defect in the range's code
3 repo-security (code blocks, static, beside the bug-prover) a demonstrated gap in a protection the repository promises
4 the owner approves the exact frozen hash, then the push happens

crafter-review's prompts, reuse keys, exit codes and shared files are pinned byte for byte by its goldens (tests/Goldens): a review one driver started, another resumes and reuses, and every driver on a machine sees the others' passes on its seat board.

Install

crafter-review ships as a Flatpak with its own git, Node (for the Playwright MCP server) and ripgrep, so every machine reviews with the same tools:

flatpak remote-add --if-not-exists catcrafts https://flatpak.catcrafts.net/catcrafts.flatpakrepo
flatpak install catcrafts net.catcrafts.CrafterReview
alias crafter-review='flatpak run net.catcrafts.CrafterReview'

master builds are the beta branch (net.catcrafts.CrafterReview//beta). The alias is for people: the /prepush skill spells every command as flatpak run net.catcrafts.CrafterReview …, because Claude's Bash tool sees no aliases.

What the machine provides:

  • The Claude Code CLI. It is proprietary and not bundled. crafter-review looks for it in this order: CLAUDE_BIN or REVIEW_GATES_CLAUDE_BIN, the PATH, the editor extensions' bundled binary (newest first), then ~/.claude/local and ~/.local/bin. It runs inside the sandbox, so every pass is measured and every pass's process tree can be killed.
  • Seats. The lens processes run on the seats in the repository's .env (CLAUDE_CODE_OAUTH_TOKEN1..6, ANTHROPIC_API_KEY1..6), else this machine's own login. crafter-review seats probes and reports them. It never prints a token.
  • Chromium, for a lens with the browser. Run crafter-review browser install once. It installs the Chromium build the pinned @playwright/mcp@0.0.83 drives into ~/.cache/ms-playwright, where the MCP server looks. It runs Playwright's own installer, which also removes the browser builds no installed Playwright on the machine refers to.
  • A local Supabase stack, for a lens with the database (supabase start, or the repository's own bring-up). The sql helper speaks the Postgres protocol itself: no psql and no driver to install. Every call is one transaction, rolled back.
  • gpg, if your commits are signed. freeze reads each commit's signature through gnupg's keyboxd socket, which is all the sandbox is given. The agent, which signs, stays out of reach.

Setting a repository up

From the repository's toplevel:

crafter-review init
crafter-review config        # edit .review-gates/config.json until it prints no problem

init does four things:

  • it writes .review-gates/config.json from the template when there is none;
  • it adds .review-gates/push/ and .review-gates/trees/ to .gitignore;
  • it writes the /prepush skill to .claude/skills/prepush/SKILL.md, which a later init refreshes (the line after its frontmatter marks it as init's);
  • it prints the next steps.

It writes nothing in a subdirectory, in your home directory (--force when that is the repository) or over a SKILL.md it did not write.

.review-gates/config.json is committed. It says what the pipeline must know about the repository:

  • who may author its commits, and which branch a range is measured against;
  • which lenses run and the environment each gets (none, browser, supabase or browser+supabase);
  • how its application is started and reached: one stack, or several side by side (slots);
  • where its local database answers;
  • which paths carry no runtime behaviour.

crafter-review doc config prints the template; crafter-review doc prepush prints the procedure, process/prepush.md.

Moving a repository off the review-gates submodule

  1. Re-freeze every review in flight with crafter-review. The Flatpak's git may be another version than the one that froze it, and a different git version gives a different hash. The old run-line.txt also points into the submodule.
  2. git submodule deinit -f review-gates && git rm review-gates
  3. crafter-review init. If .claude/skills/prepush is the old link into review-gates/, it removes the link, never writing through it, and makes a real directory with the skill.

config.json keeps working unchanged. So do the reuse keys: a range reviewed before the move is reused, not bought again.

Running a review

crafter-review freeze --slug <branch>          # Gate 0: checks, export, hash, run line
# start the application / the stack from the checkout at HEAD, when a lens has the browser / the database
crafter-review run --artifact .review-gates/push/<branch>/ --hash <sha256> \
    --base <sha> --trees . --dispositions .review-gates/push/<branch>/gate-state/dispositions.json --date <date>

freeze prints the exact run line and writes it to run-line.txt; launch from there in a detached shell (setsid nohup … &). The exit codes:

  • 0: SEND-READY (push-ready);
  • 1: FIX FIRST;
  • 2: INCOMPLETE, PARTIAL or CONFIRMING (run the same line again);
  • 3: preflight.

The dump with every finding, note and coverage entry is gate-state/commits-<hash8>-run-<n>.json.

To stop a run, run crafter-review stop <its scratch dir>, or crafter-review stop --hash <hash8> for every live run of a hash. Its running passes are killed, no later gate starts and the dump is written. A run takes its passes with it however it ends, SIGKILL included: each pass runs under a supervisor that kills its whole tree, the MCP server and Chromium included. flatpak kill net.catcrafts.CrafterReview is the hard stop.

Command What it does
freeze Gate 0: the checks, the export, the hash, the run line; --verify at push time
run Gates 1–3: the lenses, the dump; --dry-run launches nothing
slots how many stacks fit in free memory, and the commands for the missing ones
config the merged config and its problems
seats every seat probed: both windows, their resets, the drivers running
init, doc, browser install, stop the setup, the shipped texts, the Chromium, a stop
sql, totp, inventory the helpers a lens runs, and the partition of an export

Inside the Flatpak

The sandbox gets the network, the whole host filesystem (--filesystem=host), the host's /tmp and gnupg's keyboxd socket. --filesystem=host is a convenience for a developer tool, not an isolation boundary: a lens's tool allowlist is what keeps a pass to its job, as it was outside the Flatpak.

The driver hands its children the host's XDG directories. git then reads ~/.config/git/config, Playwright finds ~/.cache/ms-playwright, and claude and npx behave as on the host. A pass's shell is bash. A few things do differ from a native run:

  • a lens reading /usr sees the Sdk's;
  • git hooks run with the Sdk's tools;
  • FLATPAK_ID reaches every child;
  • a runtime update can change git between freeze and --verify, which the MISMATCH message then names.

Several drivers on one machine. Every driver registers its passes on one board, ~/.cache/review-gates/seat-board.json, and holds a lifetime lock beside it while it runs. A driver in the Flatpak publishes the host pid of its sandbox, so a driver outside it sees it alive exactly as long as it runs and sweeps it the moment it is gone.

Building from source

crafter-build --local test          # the suite; --local takes ../Crafter.Network instead of the pinned commit
crafter-build --local lint
crafter-build run flatpak           # the Flatpak on the stable Crafter.Build base (flatpak-builder or org.flatpak.Builder)
crafter-build run install           # install that build as net.catcrafts.CrafterReview//local

run flatpak --base=<branch> builds on another branch of the base app, and --deps=local takes Crafter.Network and Crafter.Thread from the checkouts next to this one, for commits not yet on forgejo. AGENTS.md is the guide for changing the pipeline.

License

crafter-review is licensed under the GNU Affero General Public License v3.0 only (LICENSE). It vendors nlohmann/json 3.12.0 (lib/json.hpp, MIT License, © 2013-2025 Niels Lohmann).

Copyright (C) 2026 Catcrafts®