Crafter.Review/tests/Goldens/fixture/commits3/0002-greet-by-name-and-document-it.patch
Jorijn van der Graaf 71dba5690f
test(pipeline): the checks of the pure pipeline
Stream, Normalize, Merge, Dispositions, Config, CodeKeys and the pure half
of CommitsMode, each a test of its own (131 checks). The fixture rewrites
are checked in (code-keys/<name>/, commits3/), so the suite reads fixtures
and edits nothing. The allowlist, command-line and MCP checks of
CommitsMode come with the pool they test.

Among them: this binary's `<exe> sql` spelling counts as a SQL call, and a
result line with a raw U+2028 in a JSON string is still the result line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-31 06:56:09 +01:00

55 lines
1.3 KiB
Diff

From 2222222222222222222222222222222222222222 Mon Sep 17 00:00:00 2001
From: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
Date: Wed, 24 Sep 2026 10:05:00 +0200
Subject: [PATCH 2/3] greet by name and document it
The greeting takes a name now and the farewell mirrors it; the README
documents both calls. Callers that pass nothing still get the old text.
The format follows the greeting spec [1].
[1] https://example.org/greeting-spec
---
README.md | 4 ++++
hello.py | 8 ++++++--
2 files changed, 10 insertions(+), 2 deletions(-)
create mode 100644 README.md
diff --git a/README.md b/README.md
new file mode 100644
index 0000000..d4e5f6a
--- /dev/null
+++ b/README.md
@@ -0,0 +1,4 @@
+# hello
+
+Call `greet(name)` or `farewell(name)`; without a name both return the
+plain text.
diff --git a/hello.py b/hello.py
index a1b2c3d..b7c8d9e 100644
--- a/hello.py
+++ b/hello.py
@@ -1,9 +1,13 @@
"""Greetings."""
-def greet():
- return "hello"
+def greet(name=None):
+ if name is None:
+ return "hello"
+ return "hello " + name
@@ -7,3 +11,5 @@ def greet():
-def farewell():
- return "bye"
+def farewell(name=None):
+ if name is None:
+ return "bye"
+ return "bye " + name
base-commit: 0000000000000000000000000000000000000000
--
2.51.0