Jorijn van der Graaf
e215ad986e
ApiConfig and PoolConfig read the seat order, the budgets and the concurrency from the process environment alone, so a `.env` that said REVIEW_GATES_SEAT_ORDER=oauth-first ordered nothing: the Python driver reads those lines from the file under the process environment (config_env, 2026-10-17: a setting lives beside the seats it orders). SeatPool::SettingsOf does the same - the file's placement settings under the process environment, in a map handed to the placement readers alone (ApiConfig, PoolConfig, Seats::ConfigFromEnv) - and leaves the process environment untouched, so no other reader sees a line of the file: a path's or a binary's line reaches nothing, and two drivers reading one .env keep one board and one ledger. The placement settings are one list, SeatPool::PlacementSettings - the fifteen names those readers read - for the map, the run's log and what makes a working directory's .env a seats file; a REVIEW_GATES_* line of any other name stays out of the map and is named, by the run's log and on `seats`'s stderr. One dotenv grammar serves the tokens and the settings (Seats::DotenvLines). `run` and `seats` resolve the file from their own --env-file (SeatPool::ResolveSeatsFile): the --env-file, else $SEATS_ENV_FILE, else the working directory's .env - the operator's, as the Python driver and `seats` read it, not the repository under review's - when it is a file holding a seat or a placement setting, each with a value, or one that cannot be read as UTF-8 text (its error is then the command's) - a readable application .env, its Vite or Supabase lines, one of blank placeholder lines or one that is no file is passed over, and the run says so - else the machine's own $XDG_CONFIG_HOME/crafter-review/env, else ~/.config/crafter-review/env: one file for every repository on a machine, a repository's seats .env winning over it. Each file is read once and the settings and the tokens are taken from that read (SeatsFile::Text), so a file that can be read only once - a pipe, `--env-file <(gpg -d seats.env.gpg)`, a FIFO - gives its settings and its seats alike, and a failed read raises its own error where the tokens are laid over the environment: SeatPool::WithFileTokens, for `run` and `seats` alike, and LoadSeats takes the merged environment and no longer reads a file by path. An empty `seats --env-file` means no file now, as it did for `run`, and the `seats` report names the side that runs first (it said "api seats run first" whatever the order). Runs, Commands and KernelModes, the tests that run `run` and `seats`, point XDG_CONFIG_HOME, and HOST_XDG_CONFIG_HOME for the Flatpak, at a path of their own that nothing creates, so a global file stays out of them; the grammar, the settings and their precedence, the lookup and the one read have their tests, a run with `--env` (a prefix) and with a repeated --env-file, and a `seats` with `--env`, take tokens and settings from the one file, an application's .env and a venv are passed over, a FIFO is read once, no line of the file reaches `stop`, every listed placement setting moves a reader, another REVIEW_GATES_* line is named and a .env of blank lines passed over, and the README, the environment table and the procedure say the new rule.
37 lines
1.7 KiB
XML
37 lines
1.7 KiB
XML
<?xml version="1.0" encoding="UTF-8"?>
|
|
<!-- SPDX-License-Identifier: CC0-1.0 -->
|
|
<component type="console-application">
|
|
<id>net.catcrafts.CrafterReview</id>
|
|
<name>Crafter Review</name>
|
|
<summary>Adversarial pre-push review of a frozen commit range</summary>
|
|
<metadata_license>CC0-1.0</metadata_license>
|
|
<project_license>AGPL-3.0-only</project_license>
|
|
<developer id="net.catcrafts">
|
|
<name>Catcrafts</name>
|
|
</developer>
|
|
<description>
|
|
<p>
|
|
The pre-push review pipeline: crafter-review freezes a commit range,
|
|
partitions it into units, and runs adversarial lenses over it — the
|
|
approach, the running application through the Playwright MCP server,
|
|
a bug proof and a security review — one claude process per unit, on the
|
|
seats the repository or the machine provides. A range is send-ready
|
|
only when every gate passes on the exact frozen hash.
|
|
</p>
|
|
</description>
|
|
<url type="homepage">https://forgejo.catcrafts.net/Catcrafts/Crafter.Review</url>
|
|
<url type="bugtracker">https://forgejo.catcrafts.net/Catcrafts/Crafter.Review/issues</url>
|
|
<url type="vcs-browser">https://forgejo.catcrafts.net/Catcrafts/Crafter.Review</url>
|
|
<provides>
|
|
<binary>crafter-review</binary>
|
|
</provides>
|
|
<content_rating type="oars-1.1"/>
|
|
<releases>
|
|
<release version="1.0.0" date="2026-10-31">
|
|
<description>
|
|
<p>First release: the pre-push review gates in C++26, shipped as a Flatpak.</p>
|
|
<p>Every lens is off until the repository's config turns it on. The commit-truth lens, repo-facts, reads the commit messages and the documentation of the range as Gate 4.</p>
|
|
</description>
|
|
</release>
|
|
</releases>
|
|
</component>
|