ofonod: keep VoiceCallManager published across imsd restarts; enable on install
GNOME Calls 50.0 builds one origin per appearance of the modem's VoiceCallManager interface and never disconnects a removed origin's CallAdded handler, so every withdraw/re-add cycle leaves a stale handler behind: calls announced twice after one cycle, a SIGBUS on freed memory after a few (measured on a Fairphone 6). Withdrawing the interface on every imsd restart or registration drop therefore cost the only incoming call path on Phosh, where Calls runs as the session's daemon. List the interface permanently. Registration is reported through the modem's Online property and enforced in Dial, which now fails with "imsd is not registered" or "imsd is not running". Only this daemon's own restart (org.ofono vanishing) still cycles the origin, and the README says to restart Calls after that. Installing the opt-in imsd-ofono subpackage now enables imsd-ofonod (a systemd preset plus the wants symlink, like imsd.service in the main package), and imsd-dialerd's autostart is limited to KDE so a Phosh session does not run the Plasma shim. Verified on the FP6 under Phosh with GNOME Calls' autostarted daemon: outgoing call, incoming call answered on the lock screen, then an imsd restart under the running Calls (Online changes only, no origin cycle) followed by another incoming call added once and answered.
This commit is contained in:
parent
590c61fe0b
commit
540ced4e32
8 changed files with 48 additions and 17 deletions
12
README.md
12
README.md
|
|
@ -173,8 +173,8 @@ private headers that no distro installs.
|
|||
Setup:
|
||||
|
||||
```sh
|
||||
apk add imsd-ofono # or install the files by hand
|
||||
systemctl enable --now imsd-ofonod # system service; org.ofono is a system name
|
||||
apk add imsd-ofono # enables imsd-ofonod via a systemd preset
|
||||
systemctl enable --now imsd-ofonod # hand installs: system service, org.ofono is a system name
|
||||
# point Calls at the ofono provider (the package ships this as a gschema
|
||||
# override; this is the per-user equivalent)
|
||||
gsettings set org.gnome.Calls autoload-plugins "['ofono']"
|
||||
|
|
@ -218,13 +218,17 @@ Known gaps, all inherited rather than introduced:
|
|||
normal dialpad is unaffected — that reaches imsd's own classifier.
|
||||
- DTMF is forwarded to imsd, where `SendDtmf` is still a stub (RFC 4733 is not
|
||||
implemented yet) — the same limitation Plasma has.
|
||||
- **Restart GNOME Calls after restarting `imsd-ofonod` (or imsd).** When the
|
||||
- **Restart GNOME Calls after restarting `imsd-ofonod` itself.** When the
|
||||
modem's `VoiceCallManager` interface goes away and comes back, Calls 50.0
|
||||
adds a new origin but leaves the old origin's `CallAdded` handler connected:
|
||||
after one such cycle every call is added twice, after a few the stale handler
|
||||
runs on freed memory and Calls dies with SIGBUS in `g_hash_table_lookup`
|
||||
(measured on the FP6). Calls-side; an upstream fix belongs in
|
||||
`plugins/provider/ofono/calls-ofono-provider.c`.
|
||||
`plugins/provider/ofono/calls-ofono-provider.c`. To keep imsd's own
|
||||
restarts and registration drops from triggering it, `imsd-ofonod` lists the
|
||||
interface permanently: `Online` tracks registration, and `Dial` fails with
|
||||
"imsd is not registered" / "imsd is not running" instead. Only `org.ofono`
|
||||
vanishing — this daemon restarting — still cycles the origin.
|
||||
|
||||
Development, without a phone or root:
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue