Catcrafts/imsd
Watch
2
0
Fork
You've already forked imsd
 0
Code Issues Pull requests Projects Releases 5 Packages 1 Wiki Activity Actions

imsd, imsd-ofonod: let polkit decide call control, not the account name

Browse source 
The system-bus policies granted net.catcrafts.IMS1 and org.ofono to root
and to the account `user`, postmarketOS's default name, so on a unit
whose account is called something else dbus denied every Dial from the
dialer — nothing in imsd's journal, nothing on screen. A field user
found it by trial (alyx report 14, 2026-09-20; ims ledger F14).

Let any local account reach both names and have the daemons decide:
placing, answering or ending a call needs polkit's
net.catcrafts.IMS1.Voice (the active local session; not an ssh login, an
inactive session or a system service account). imsd-ofonod asks about
its own callers, since its calls reach imsd as root. Reads such as the
status and the call list are not gated, and a refusal is logged with the
sender; a `--session` run, the development mode without root or polkit,
leaves the gate off. The check is ImsdBus, a small GLib module both
daemons link; the package depends on polkit.

An upgrade restarts both daemons (the previous commit), so the open
policy faces the old, ungated daemons only until the apk transaction
ends.

Tested on the dev phone (KPN) in builds of this series; not every path
has run there.
This commit is contained in:
Jorijn van der Graaf 2026-10-03 20:44:58 +02:00
commit f18baf2790
Signed by: jorijnvdgraaf
GPG key ID: 2937E59CDCC1BCFB
13 changed files with 245 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

31
README.md
View file

@ -25,11 +25,12 @@ every decision — SIP framing, SDP selection, the AKAv1-MD5 digest, the
`ip xfrm` command sequence, and the whole call FSM — is unit-tested on a dev
box with no bus, modem, or phone; several suites pin output byte-for-byte
against recorded network traffic. GLib/GDBus, sockets, and subprocess control
live only in the `imsd` daemon shell.
live only in the `imsd` daemon shell, apart from imsd-bus, the GLib polkit
gate it shares with imsd-ofonod.
## Architecture
C++26 modules, built with Crafter Build. Five build products:
C++26 modules, built with Crafter Build. Six build products:
- **imsd-core** (static library) — the engine, pure `import std` C++ with no
GLib and no I/O side effects. Everything here is unit-testable on any dev
@ -37,7 +38,12 @@ C++26 modules, built with Crafter Build. Five build products:
byte-for-byte against recorded network traffic.
- **imsd** (executable) — the daemon shell: GLib main loop, GDBus service,
sockets, subprocess control (`qmicli`/`mmcli`/`ip`), and the registration
sequence + run loop that pumps the core. All GLib and I/O live here.
sequence + run loop that pumps the core.
- **imsd-bus** (static library) — the polkit gate in front of call control
(`net.catcrafts.IMS1.Voice`), which imsd and imsd-ofonod both link. GLib,
so kept outside imsd-core. A translation daemon that runs as root on the
system bus reaches imsd as root, which polkit always allows, so it gates
its own callers through this or it is a bypass.
- **imsd-media** (executable) — the RTP/AMR-WB data plane, spawned once per
call. Pure `import std` + POSIX, no GLib; links `-ldl` and dlopen's the
codecs. A separate process for crash isolation and the far-end-hangup
@ -52,7 +58,8 @@ C++26 modules, built with Crafter Build. Five build products:
- **imsd-ofonod** (executable) — the GNOME Calls integration, for Phosh and
GNOME Mobile: a system daemon owning `org.ofono` and presenting imsd as an
oFono modem, which is the seam GNOME Calls' bundled `ofono` provider plugin
drives. GDBus translation only, no core; built with `-- --product=ofonod`.
drives. GDBus translation, no core, plus the imsd-bus gate on its own
callers; built with `-- --product=ofonod`.
See [GNOME Calls (Phosh, GNOME Mobile)](#gnome-calls-phosh-gnome-mobile).
### Desktop integration
@ -144,10 +151,12 @@ crafter-build -- --target=aarch64-alpine-linux-musl \
busctl --user call net.catcrafts.IMS1 /net/catcrafts/IMS1 net.catcrafts.IMS1 GetStatus
```
On a phone the daemon runs as root on the system bus (policy in
`packaging/net.catcrafts.IMS1.conf` — it grants the postmarketOS default
account `user` access; adjust it if your session account is named
differently), started by `packaging/imsd.service`
On a phone the daemon runs as root on the system bus, where any local
account may reach it (`packaging/net.catcrafts.IMS1.conf`); placing,
answering and ending a call is polkit's `net.catcrafts.IMS1.Voice`
(`packaging/net.catcrafts.IMS1.policy`, checked by imsd and imsd-ofonod
alike): the active local session — the dialer, whatever the account is
called — and root, not an ssh login. It is started by `packaging/imsd.service`
after `packaging/ims-pdn-up.sh` has brought up the ims PDN through
ModemManager. An apk upgrade restarts `imsd` and `imsd-ofonod` once the
transaction is done (a call in progress ends), as does adding a package
@ -398,8 +407,10 @@ integrations depend on it:
| `CallDeleted` | `s` |
| `RegistrationChanged` | `b` |
Both `imsd-dialerd` and `imsd-ofonod` are pure translations of this ABI; a new
desktop needs a new translation daemon, not changes here.
Both `imsd-dialerd` and `imsd-ofonod` translate this ABI and add no members
to it; a new desktop needs a new translation daemon, not changes here — one
that runs as root on the system bus also gates its own callers through
imsd-bus (see Architecture), or it bypasses `net.catcrafts.IMS1.Voice`.
## License