Jorijn van der Graaf
2fe991a14e
An upgrade left the old imsd and imsd-ofonod running until they were next restarted, while a changed bus policy is live the moment apk writes it: dbus-broker-launch reloads on its own. A policy that relies on a check inside the daemons would face the old daemons in between. Mark imsd.service and imsd-ofonod.service needs-restart in post-upgrade scripts; the systemd trigger restarts them once the transaction is done (enqueue-marked). A call in progress ends. The same scripts run as post-install: `apk del` removes a package's files and leaves its daemon running, so a later `apk add` of the package is this upgrade for that daemon — and apk runs the post-install script, not post-upgrade, for a package it adds. GNOME Calls 50.0 dials nothing after imsd-ofonod restarts under it until it restarts too, so imsd-ofonod's ExecStartPost restarts the Calls daemon of each user running one — not at the unit's first start since boot, when a Calls that runs already is left alone. A daemon older than 0.3.10 kept its bring-up throttle wait in memory only, so a restart lost it. imsd's post-upgrade records that daemon's invocation, and imsd-handover.sh, an ExecStartPre after ims-pdn-up.sh, reads the invocation's journal and, while the fresh-SA throttle's wait it finds there still runs (`spi-s=0`; the old daemon's other deferrals are not handed over), writes what is left of it to the holds file when this start's LOCAL is the address the wait was earned on, or when that address cannot be read; when LOCAL is another address, only the verdict that the old registration is gone. Tested on the dev phone (KPN) in builds of this series; not every path has run there.
24 lines
1.2 KiB
Shell
Executable file
24 lines
1.2 KiB
Shell
Executable file
#!/bin/sh
|
|
# SPDX-License-Identifier: GPL-3.0-only
|
|
# SPDX-FileCopyrightText: Copyright (C) 2026 Catcrafts®
|
|
#
|
|
# ExecStartPost of imsd-ofonod.service. GNOME Calls 50.0 keeps a stale modem
|
|
# when org.ofono vanishes and dials nothing until it is restarted (README,
|
|
# Known gaps), so every start of imsd-ofonod after org.ofono went away
|
|
# restarts the Calls daemon of each user running one. Its first start since
|
|
# boot is not one: no Calls has seen org.ofono go, and a Calls that runs
|
|
# already (a login during the bring-up) is left alone. The unit's own
|
|
# timestamp tells the first start from a restart (an upgrade from 0.3.9 is
|
|
# a restart); the marker covers a stop and a later start.
|
|
marker=/run/imsd-ofonod.started
|
|
if [ ! -e "$marker" ] && [ "$(systemctl show -P ActiveExitTimestampMonotonic imsd-ofonod.service)" = 0 ]; then
|
|
: > "$marker"
|
|
echo "imsd-ofono-restart-calls: first start since boot, Calls left alone"
|
|
exit 0
|
|
fi
|
|
: > "$marker"
|
|
for uid in $(systemctl list-units 'user@*.service' --legend=no --plain | sed -n 's/^user@\([0-9]*\)\.service.*/\1/p'); do
|
|
echo "imsd-ofono-restart-calls: restarting the Calls daemon of uid $uid, if it runs"
|
|
systemctl --user -M "$uid@" try-restart --no-block calls-daemon.service || :
|
|
done
|
|
exit 0
|