Jorijn van der Graaf
e31887bf21
Keys pressed on the other phone reached imsd-media as RFC 4733 events and were dropped with every packet that is not the audio's. The playout now takes them: the gap before an event's start (a stock sender's DTX silence often precedes a key press) is filled as before an audio frame, each packet reports the event's duration so far from its start stamp, and what the clock has not covered yet is synthesized as the event's Q.23 frequency pair at the packet's volume, so a retransmitted end packet adds nothing, a lost update is caught up by the next, and a far end whose audio resumes past the event (the stock phone's does) meets the clock with the usual fill. An answer may renumber telephone-event from what we offered (RFC 3264: the answerer sends with the offer's numbers, §6.1, and the offerer with the answer's, §5.1), so the leg gets both: DTMF_PT to send with, DTMF_RX_PT to take events at as well — our own SDP's number: the offer's 98 or 100 on a call we placed, the offer's number we echoed on one we answered; when the answer gave the audio our offer's number, that number is the leg's audio and DTMF_RX_PT is the answer's telephone-event number instead — and takes events at either number, never at the audio's. --selftest pins the frequency table; the stats gain rx_dtmf, tones and dtmf_rx_pt. Tested: --selftest, tests/Sdp and tests/Engine (the eight suites pass); the loopback's --dtmf-rx arm on a host build of this commit's tree (journal/ims/captures/2026-10-15-dtmf-loopback-c3-rx.txt; the tx, both, plain and collision runs beside it); the dev phone's dtmf benches ran in builds of this series.
401 lines
20 KiB
C++
401 lines
20 KiB
C++
// SPDX-License-Identifier: GPL-3.0-only
|
|
// SPDX-FileCopyrightText: Copyright (C) 2026 Catcrafts®
|
|
|
|
// lint-disable-file fixed-width-types
|
|
// Imsd:Sdp unit tests — offer building (byte-exact) and answer parsing
|
|
// (payload-type preference, octet-align, address family). The IPv6 answer
|
|
// mirrors what a live commercial IMS core actually returns (AMR-WB pt=97
|
|
// octet-aligned, IPv6 media gateway).
|
|
import std;
|
|
import Imsd;
|
|
|
|
using namespace imsd::sdp;
|
|
|
|
namespace {
|
|
int Failures = 0;
|
|
|
|
void Check(bool cond, std::string_view msg) {
|
|
if (!cond) {
|
|
std::println(std::cerr, "FAIL: {}", msg);
|
|
++Failures;
|
|
}
|
|
}
|
|
}
|
|
|
|
int main() {
|
|
// ---- BuildOffer, IPv6 + preconditions (the shape a VoLTE UE sends)
|
|
{
|
|
std::string sdp = BuildOffer({
|
|
.local = "2001:db8:29e9:a05f::1",
|
|
.rtpPort = 22222,
|
|
.sessionId = 1234567,
|
|
.precond = true,
|
|
});
|
|
std::string expected =
|
|
"v=0\r\n"
|
|
"o=- 1234567 1234567 IN IP6 2001:db8:29e9:a05f::1\r\n"
|
|
"s=-\r\n"
|
|
"c=IN IP6 2001:db8:29e9:a05f::1\r\n"
|
|
"t=0 0\r\n"
|
|
"m=audio 22222 RTP/AVP 97 99 98 100\r\n"
|
|
"b=AS:41\r\n"
|
|
"b=RS:512\r\n"
|
|
"b=RR:1536\r\n"
|
|
"a=rtpmap:97 AMR-WB/16000/1\r\n"
|
|
"a=fmtp:97 octet-align=1;mode-change-capability=2;max-red=0\r\n"
|
|
"a=rtpmap:99 AMR/8000/1\r\n"
|
|
"a=fmtp:99 octet-align=1;mode-change-capability=2;max-red=0\r\n"
|
|
"a=rtpmap:98 telephone-event/16000\r\n"
|
|
"a=fmtp:98 0-15\r\n"
|
|
"a=rtpmap:100 telephone-event/8000\r\n"
|
|
"a=fmtp:100 0-15\r\n"
|
|
"a=ptime:20\r\n"
|
|
"a=maxptime:240\r\n"
|
|
"a=curr:qos local sendrecv\r\n"
|
|
"a=curr:qos remote none\r\n"
|
|
"a=des:qos mandatory local sendrecv\r\n"
|
|
"a=des:qos mandatory remote sendrecv\r\n"
|
|
"a=sendrecv\r\n";
|
|
Check(sdp == expected, "IPv6 precondition offer is byte-exact");
|
|
}
|
|
// ---- BuildOffer, IPv4 without preconditions
|
|
{
|
|
std::string sdp = BuildOffer({
|
|
.local = "10.0.0.2",
|
|
.rtpPort = 4000,
|
|
.sessionId = 42,
|
|
.precond = false,
|
|
});
|
|
Check(sdp.contains("o=- 42 42 IN IP4 10.0.0.2\r\n"), "IPv4 origin line");
|
|
Check(sdp.contains("c=IN IP4 10.0.0.2\r\n"), "IPv4 connection line");
|
|
Check(!sdp.contains("a=curr:qos"), "no precondition block");
|
|
Check(sdp.ends_with("a=sendrecv\r\n"), "trailing sendrecv + CRLF");
|
|
}
|
|
|
|
// ---- ParseAnswer, real-world IPv6 answer
|
|
{
|
|
Answer a = ParseAnswer(
|
|
"v=0\r\n"
|
|
"o=- 99 99 IN IP6 2001:db8::307\r\n"
|
|
"s=-\r\n"
|
|
"c=IN IP6 2001:db8::307\r\n"
|
|
"t=0 0\r\n"
|
|
"m=audio 35868 RTP/AVP 97 98\r\n"
|
|
"a=rtpmap:97 AMR-WB/16000/1\r\n"
|
|
"a=fmtp:97 octet-align=1;mode-change-capability=2\r\n"
|
|
"a=rtpmap:98 telephone-event/16000\r\n"
|
|
"a=ptime:20\r\n");
|
|
Check(a.ip == "2001:db8::307", "answer IP6");
|
|
Check(a.port == 35868, "answer port");
|
|
Check(a.payloadType == 97, "answer payload type");
|
|
Check(a.octetAlign, "answer octet-align");
|
|
Check(a.codec == "AMR-WB", "answer codec");
|
|
}
|
|
// ---- payload-type preference: AMR remembered, later AMR-WB overrides
|
|
{
|
|
Answer a = ParseAnswer("c=IN IP4 192.0.2.1\r\n" "m=audio 5000 RTP/AVP 96 97\r\n" "a=rtpmap:96 AMR/8000/1\r\n" "a=rtpmap:97 AMR-WB/16000/1\r\n");
|
|
Check(a.payloadType == 97, "AMR-WB preferred over earlier AMR");
|
|
Check(a.codec == "AMR-WB", "codec follows the preferred rtpmap");
|
|
}
|
|
// ---- octet-aligned AMR-WB preferred over an earlier BE AMR-WB
|
|
// (the s56 MT-static shape: an offer listing bandwidth-efficient first)
|
|
{
|
|
Answer a = ParseAnswer(
|
|
"c=IN IP6 2001:db8::1\r\n"
|
|
"m=audio 5000 RTP/AVP 116 118 110\r\n"
|
|
"a=rtpmap:116 AMR-WB/16000/1\r\n"
|
|
"a=fmtp:116 mode-change-capability=2;max-red=0\r\n"
|
|
"a=rtpmap:118 AMR-WB/16000/1\r\n"
|
|
"a=fmtp:118 octet-align=1;mode-change-capability=2\r\n"
|
|
"a=rtpmap:110 telephone-event/16000\r\n");
|
|
Check(a.payloadType == 118, "octet-aligned AMR-WB wins over earlier BE");
|
|
Check(a.octetAlign, "octet-align follows the chosen pt");
|
|
Check(a.codec == "AMR-WB", "codec is AMR-WB");
|
|
}
|
|
// ---- BE-only AMR-WB offer stays BE at the first pt
|
|
{
|
|
Answer a = ParseAnswer(
|
|
"c=IN IP6 2001:db8::1\r\n"
|
|
"m=audio 5000 RTP/AVP 116 96\r\n"
|
|
"a=rtpmap:116 AMR-WB/16000/1\r\n"
|
|
"a=fmtp:116 mode-change-capability=2\r\n"
|
|
"a=rtpmap:96 AMR/8000/1\r\n"
|
|
"a=fmtp:96 octet-align=1\r\n");
|
|
Check(a.payloadType == 116, "BE-only AMR-WB beats octet-aligned AMR");
|
|
Check(!a.octetAlign, "BE-only offer negotiates bandwidth-efficient");
|
|
}
|
|
// ---- AMR-only answer
|
|
{
|
|
Answer a = ParseAnswer("c=IN IP4 192.0.2.1\r\n" "m=audio 5000 RTP/AVP 96\r\n" "a=rtpmap:96 AMR/8000/1\r\n" "a=fmtp:96 octet-align=1\r\n");
|
|
Check(a.payloadType == 96 && a.codec == "AMR", "plain AMR fallback");
|
|
Check(a.octetAlign, "octet-align seen for AMR too");
|
|
}
|
|
// ---- G.711 by static payload type, no rtpmap at all (RFC 3551 §6):
|
|
// the shape a PSTN gateway sends for a landline caller
|
|
{
|
|
Answer a = ParseAnswer("c=IN IP4 192.0.2.1\r\n" "m=audio 5000 RTP/AVP 0 8\r\n");
|
|
Check(a.payloadType == 8, "PCMA preferred over an earlier PCMU");
|
|
Check(a.codec == "PCMA", "static pt 8 -> PCMA without an rtpmap line");
|
|
Check(!a.octetAlign, "G.711 never octet-aligned");
|
|
}
|
|
{
|
|
Answer a = ParseAnswer("c=IN IP4 192.0.2.1\r\n" "m=audio 5000 RTP/AVP 0\r\n");
|
|
Check(a.payloadType == 0 && a.codec == "PCMU", "static pt 0 -> PCMU");
|
|
}
|
|
// ---- G.711 with an rtpmap, lower-case name (RFC 4566: case-insensitive)
|
|
{
|
|
Answer a = ParseAnswer("c=IN IP4 192.0.2.1\r\n" "m=audio 5000 RTP/AVP 8 101\r\n" "a=rtpmap:8 pcma/8000\r\n" "a=rtpmap:101 telephone-event/8000\r\n");
|
|
Check(a.payloadType == 8 && a.codec == "PCMA", "lower-case rtpmap name still recognised");
|
|
}
|
|
{
|
|
Answer a = ParseAnswer("c=IN IP6 2001:db8::1\r\n" "m=audio 5000 RTP/AVP 96\r\n" "a=rtpmap:96 amr-wb/16000/1\r\n" "a=fmtp:96 octet-align=1\r\n");
|
|
Check(a.payloadType == 96 && a.codec == "AMR-WB" && a.octetAlign, "lower-case amr-wb recognised, octet-align kept");
|
|
}
|
|
// ---- narrowband AMR beats G.711 (a gateway listing both)
|
|
{
|
|
Answer a = ParseAnswer("c=IN IP4 192.0.2.1\r\n" "m=audio 5000 RTP/AVP 8 100 101\r\n" "a=rtpmap:100 AMR/8000/1\r\n" "a=fmtp:100 octet-align=1\r\n" "a=rtpmap:101 telephone-event/8000\r\n");
|
|
Check(a.payloadType == 100 && a.codec == "AMR", "AMR preferred over PCMA listed first");
|
|
Check(a.octetAlign, "AMR octet-align seen");
|
|
}
|
|
// ---- wideband beats everything: KPN's real mobile-origin list
|
|
// (AMR-WB BE 116, AMR-WB OA 107, PCMA 8, AMR 100, DTMF 111/110, CN 13)
|
|
{
|
|
Answer a = ParseAnswer(
|
|
"c=IN IP6 2001:db8::310\r\n"
|
|
"m=audio 5000 RTP/AVP 116 107 8 100 111 110 13\r\n"
|
|
"a=rtpmap:116 AMR-WB/16000/1\r\n"
|
|
"a=fmtp:116 mode-change-capability=2;max-red=0\r\n"
|
|
"a=rtpmap:107 AMR-WB/16000/1\r\n"
|
|
"a=fmtp:107 octet-align=1;mode-change-capability=2;max-red=0\r\n"
|
|
"a=rtpmap:100 AMR/8000/1\r\n"
|
|
"a=rtpmap:111 telephone-event/16000\r\n"
|
|
"a=rtpmap:110 telephone-event/8000\r\n"
|
|
"a=rtpmap:13 CN/8000\r\n");
|
|
Check(a.payloadType == 107 && a.codec == "AMR-WB" && a.octetAlign, "mobile caller still lands on octet-aligned AMR-WB");
|
|
}
|
|
// ---- nothing we play -> first payload type, codec EMPTY (the 488 case)
|
|
{
|
|
Answer a = ParseAnswer("c=IN IP4 192.0.2.1\r\n" "m=audio 5000 RTP/AVP 18 101\r\n" "a=rtpmap:18 G729/8000\r\n" "a=rtpmap:101 telephone-event/8000\r\n");
|
|
Check(a.payloadType == 18, "no playable codec -> first payload type");
|
|
Check(!a.octetAlign, "no fmtp -> bandwidth-efficient");
|
|
Check(a.codec.empty(), "G729-only -> codec unknown, not assumed");
|
|
}
|
|
|
|
// ---- OfferedCodecs: the 488 log summary
|
|
{
|
|
Check(OfferedCodecs("m=audio 5000 RTP/AVP 18 101\r\na=rtpmap:18 G729/8000\r\na=rtpmap:101 telephone-event/8000\r\n") == "18 G729, 101 TELEPHONE-EVENT", "offered list names each pt");
|
|
Check(OfferedCodecs("m=audio 5000 RTP/AVP 0 8\r\n") == "0 PCMU, 8 PCMA", "static G.711 types named without rtpmap");
|
|
Check(OfferedCodecs("m=audio 5000 RTP/AVP 96\r\n") == "96", "unknown dynamic pt listed bare");
|
|
Check(OfferedCodecs("v=0\r\n") == "no m=audio line", "no audio line says so");
|
|
}
|
|
// ---- CodecRate
|
|
{
|
|
Check(CodecRate("AMR-WB") == 16000, "AMR-WB is 16 kHz");
|
|
Check(CodecRate("AMR") == 8000 && CodecRate("PCMA") == 8000 && CodecRate("PCMU") == 8000, "narrowband codecs are 8 kHz");
|
|
}
|
|
// ---- degenerate body
|
|
{
|
|
Answer a = ParseAnswer("v=0\r\n");
|
|
Check(a.ip.empty() && a.port == -1 && a.payloadType == -1, "empty answer parses to absent fields");
|
|
}
|
|
|
|
// ---- TelephoneEventPt
|
|
{
|
|
std::string_view offer =
|
|
"m=audio 27864 RTP/AVP 104 105\r\n"
|
|
"a=rtpmap:104 AMR-WB/16000/1\r\n"
|
|
"a=rtpmap:105 telephone-event/16000\r\n"
|
|
"a=rtpmap:106 telephone-event/8000\r\n";
|
|
Check(OfferedTelephoneEventPt(16000) == 98 && OfferedTelephoneEventPt(8000) == 100, "our offer's telephone-event numbers per clock");
|
|
Check(TelephoneEventPt(offer, 16000) == 105, "telephone-event pt by clock rate");
|
|
Check(!TelephoneEventPt(offer, 8000), "an rtpmap the m-line does not list (106 among 104 105) is not negotiated");
|
|
Check(ParseAnswer(offer).dtmfPt == 105, "the answer's dtmfPt is the one at the chosen codec's clock (AMR-WB: 16000)");
|
|
std::string both = std::format("{}a=rtpmap:99 AMR/8000/1\r\n", offer);
|
|
both.replace(both.find("RTP/AVP 104 105"), 15, "RTP/AVP 104 99 105 106");
|
|
std::array<std::string, 1> nb = {"AMR"};
|
|
Check(ParseAnswer(both, nb).dtmfPt == 106, "...and the narrowband one when AMR is chosen");
|
|
Check(TelephoneEventPt(both, 8000) == 106, "listed on the m-line, the narrowband telephone-event pt is found");
|
|
Check(!ParseAnswer(offer, nb).dtmfPt, "no codec we play chosen: no dtmfPt either");
|
|
Check(!ParseAnswer("c=IN IP4 192.0.2.1\r\n" "m=audio 5000 RTP/AVP 8\r\n" "a=rtpmap:8 PCMA/8000\r\n").dtmfPt, "no telephone-event in the answer: dtmfPt empty");
|
|
Check(!ParseAnswer("c=IN IP4 192.0.2.1\r\n" "m=audio 5000 RTP/AVP 8\r\n" "a=rtpmap:8 PCMA/8000\r\n" "a=rtpmap:101 telephone-event/8000\r\n").dtmfPt, "the answer dropped telephone-event from its m-line and kept the rtpmap: not negotiated (RFC 3264 §8.3.2: nothing is sent with a format the answer does not list)");
|
|
Check(ParseAnswer("c=IN IP4 192.0.2.1\r\n" "m=audio 5000 RTP/AVP 8 101\r\n" "a=rtpmap:101 telephone-event/8000\r\n").dtmfPt == 101, "G.711 answer with telephone-event/8000: dtmfPt 101");
|
|
Check(!ParseAnswer("c=IN IP4 192.0.2.1\r\n" "m=audio 5000 RTP/AVP 8 101\r\n" "a=rtpmap:101 telephone-event/16000\r\n").dtmfPt, "telephone-event at the wrong clock for the codec is not the call's");
|
|
Check(ParseAnswer("c=IN IP4 192.0.2.1\r\n" "m=audio 5000 RTP/AVP 8 101\r\n" "a=rtpmap:101 TELEPHONE-EVENT/8000\r\n").dtmfPt == 101, "the name in another case (RFC 4566: case-insensitive)");
|
|
Check(TelephoneEventPt("m=audio 1 RTP/AVP 98\r\na=rtpmap:98 Telephone-Event/16000/1\r\n", 16000) == 98, "mixed case, with a channel count");
|
|
Check(!TelephoneEventPt("m=audio 1 RTP/AVP 98\r\na=rtpmap:98 telephone-event/80000\r\n", 8000), "the clock is matched whole: /80000 is not /8000");
|
|
Check(!TelephoneEventPt(offer, 48000).has_value(), "absent clock rate -> nullopt");
|
|
Check(!TelephoneEventPt("m=audio 1 RTP/AVP 0\r\n", 16000).has_value(), "no rtpmap -> nullopt");
|
|
}
|
|
|
|
// ---- BuildAnswer: the offer's own payload types, octet-align mirrored
|
|
{
|
|
std::string sdp = BuildAnswer({
|
|
.local = "2001:db8:29e9:a05f::1",
|
|
.rtpPort = 50004,
|
|
.sessionId = 777,
|
|
.payloadType = 104,
|
|
.octetAlign = true,
|
|
.codec = "AMR-WB",
|
|
.dtmfPt = 105,
|
|
});
|
|
std::string expected =
|
|
"v=0\r\n"
|
|
"o=- 777 777 IN IP6 2001:db8:29e9:a05f::1\r\n"
|
|
"s=-\r\n"
|
|
"c=IN IP6 2001:db8:29e9:a05f::1\r\n"
|
|
"t=0 0\r\n"
|
|
"m=audio 50004 RTP/AVP 104 105\r\n"
|
|
"b=AS:41\r\n"
|
|
"b=RS:512\r\n"
|
|
"b=RR:1536\r\n"
|
|
"a=rtpmap:104 AMR-WB/16000/1\r\n"
|
|
"a=fmtp:104 octet-align=1\r\n"
|
|
"a=rtpmap:105 telephone-event/16000\r\n"
|
|
"a=fmtp:105 0-15\r\n"
|
|
"a=ptime:20\r\n"
|
|
"a=maxptime:240\r\n"
|
|
"a=sendrecv\r\n";
|
|
Check(sdp == expected, "AMR-WB answer is byte-exact");
|
|
}
|
|
// ---- BuildAnswer: bandwidth-efficient offer, no DTMF, narrowband
|
|
{
|
|
std::string sdp = BuildAnswer({
|
|
.local = "10.0.0.2",
|
|
.rtpPort = 4000,
|
|
.sessionId = 8,
|
|
.payloadType = 96,
|
|
.octetAlign = false,
|
|
.codec = "AMR",
|
|
});
|
|
Check(sdp.contains("m=audio 4000 RTP/AVP 96\r\n"), "single-pt m-line");
|
|
Check(sdp.contains("a=rtpmap:96 AMR/8000/1\r\n"), "narrowband rtpmap");
|
|
Check(!sdp.contains("octet-align"), "bandwidth-efficient stays unmarked");
|
|
Check(!sdp.contains("telephone-event"), "no DTMF when the offer had none");
|
|
Check(sdp.contains("b=AS:30\r\n"), "narrowband bandwidth");
|
|
}
|
|
// ---- BuildAnswer: G.711 for a landline caller — static pt, no fmtp,
|
|
// narrowband DTMF, byte-exact
|
|
{
|
|
std::string sdp = BuildAnswer({
|
|
.local = "2001:db8:29e9:a05f::1",
|
|
.rtpPort = 50004,
|
|
.sessionId = 778,
|
|
.payloadType = 8,
|
|
.octetAlign = false,
|
|
.codec = "PCMA",
|
|
.dtmfPt = 101,
|
|
});
|
|
std::string expected =
|
|
"v=0\r\n"
|
|
"o=- 778 778 IN IP6 2001:db8:29e9:a05f::1\r\n"
|
|
"s=-\r\n"
|
|
"c=IN IP6 2001:db8:29e9:a05f::1\r\n"
|
|
"t=0 0\r\n"
|
|
"m=audio 50004 RTP/AVP 8 101\r\n"
|
|
"b=AS:80\r\n"
|
|
"b=RS:512\r\n"
|
|
"b=RR:1536\r\n"
|
|
"a=rtpmap:8 PCMA/8000/1\r\n"
|
|
"a=rtpmap:101 telephone-event/8000\r\n"
|
|
"a=fmtp:101 0-15\r\n"
|
|
"a=ptime:20\r\n"
|
|
"a=maxptime:240\r\n"
|
|
"a=sendrecv\r\n";
|
|
Check(sdp == expected, "PCMA answer is byte-exact");
|
|
}
|
|
// ---- BuildAnswer never marks G.711 octet-aligned even if asked
|
|
{
|
|
std::string sdp = BuildAnswer({.local = "10.0.0.2", .rtpPort = 4000, .sessionId = 9, .payloadType = 0, .octetAlign = true, .codec = "PCMU"});
|
|
Check(sdp.contains("a=rtpmap:0 PCMU/8000/1\r\n") && !sdp.contains("fmtp:0"), "PCMU answer has no fmtp");
|
|
}
|
|
|
|
// ---- CODECS override: the offer of a real interconnect gateway that
|
|
// transcodes up (KPN, 2026-09-08: a G.711-only caller arrives with
|
|
// AMR-WB BE added). Default picks AMR-WB; a preference list picks
|
|
// what it names, in its order, and nothing outside it.
|
|
{
|
|
std::string kpn =
|
|
"c=IN IP6 2001:db8::309\r\n"
|
|
"m=audio 41166 RTP/AVP 8 0 100 96 101 13 106\r\n"
|
|
"a=rtpmap:8 PCMA/8000\r\na=rtpmap:0 PCMU/8000\r\n"
|
|
"a=rtpmap:100 AMR/8000\r\na=fmtp:100 mode-change-period=2\r\n"
|
|
"a=rtpmap:96 AMR-WB/16000\r\na=fmtp:96 mode-change-period=2\r\n"
|
|
"a=rtpmap:101 telephone-event/8000\r\na=fmtp:101 0-15\r\n"
|
|
"a=rtpmap:106 telephone-event/16000\r\na=fmtp:106 0-15\r\n"
|
|
"a=sendrecv\r\na=ptime:20\r\na=maxptime:60\r\n";
|
|
Answer d = ParseAnswer(kpn);
|
|
Check(d.payloadType == 96 && d.codec == "AMR-WB" && !d.octetAlign, "transcoding gateway: default takes AMR-WB BE");
|
|
std::vector<std::string> pcma{"PCMA"};
|
|
Answer a = ParseAnswer(kpn, pcma);
|
|
Check(a.payloadType == 8 && a.codec == "PCMA" && !a.octetAlign, "CODECS=PCMA takes G.711 A-law out of a mixed offer");
|
|
std::vector<std::string> ulawFirst{"PCMU", "PCMA"};
|
|
Answer u = ParseAnswer(kpn, ulawFirst);
|
|
Check(u.payloadType == 0 && u.codec == "PCMU", "CODECS order wins over the offer's order");
|
|
std::vector<std::string> nb{"AMR"};
|
|
Answer n = ParseAnswer(kpn, nb);
|
|
Check(n.payloadType == 100 && n.codec == "AMR" && !n.octetAlign, "CODECS=AMR takes narrowband AMR, BE as offered");
|
|
std::vector<std::string> wb{"AMR-WB"};
|
|
Answer w = ParseAnswer(kpn, wb);
|
|
Check(w.payloadType == 96 && w.codec == "AMR-WB", "CODECS=AMR-WB matches the default here");
|
|
Answer g = ParseAnswer("c=IN IP4 192.0.2.1\r\n" "m=audio 5000 RTP/AVP 8 0 101\r\n" "a=rtpmap:101 telephone-event/8000\r\n", wb);
|
|
Check(g.codec.empty() && g.payloadType == 8, "CODECS=AMR-WB refuses a G.711-only offer (codec empty, first pt)");
|
|
Check(g.port == 5000 && g.ip == "192.0.2.1", "address/port still parsed when no codec is acceptable");
|
|
}
|
|
|
|
// ---- ParseCodecList: case, spaces, AMR-NB alias, unknowns, repeats
|
|
{
|
|
auto l = ParseCodecList("pcma, amr-nb ,AMR-WB,g729,PCMA,,PCMU");
|
|
Check(l.size() == 4 && l[0] == "PCMA" && l[1] == "AMR" && l[2] == "AMR-WB" && l[3] == "PCMU", "codec list normalised: PCMA,AMR,AMR-WB,PCMU");
|
|
Check(ParseCodecList("").empty(), "empty spec = no override");
|
|
Check(ParseCodecList("opus, g722").empty(), "only unknown names = no override");
|
|
}
|
|
|
|
// ---- BuildOffer with an explicit codec list: G.711 only (landline
|
|
// shape, for MO tests against a transcoding network)
|
|
{
|
|
std::string sdp = BuildOffer({
|
|
.local = "192.0.2.1",
|
|
.rtpPort = 22222,
|
|
.sessionId = 1234567,
|
|
.codecs = {"PCMA", "PCMU"},
|
|
});
|
|
std::string expected =
|
|
"v=0\r\n"
|
|
"o=- 1234567 1234567 IN IP4 192.0.2.1\r\n"
|
|
"s=-\r\n"
|
|
"c=IN IP4 192.0.2.1\r\n"
|
|
"t=0 0\r\n"
|
|
"m=audio 22222 RTP/AVP 8 0 100\r\n"
|
|
"b=AS:80\r\n"
|
|
"b=RS:512\r\n"
|
|
"b=RR:1536\r\n"
|
|
"a=rtpmap:8 PCMA/8000/1\r\n"
|
|
"a=rtpmap:0 PCMU/8000/1\r\n"
|
|
"a=rtpmap:100 telephone-event/8000\r\n"
|
|
"a=fmtp:100 0-15\r\n"
|
|
"a=ptime:20\r\n"
|
|
"a=maxptime:240\r\n"
|
|
"a=sendrecv\r\n";
|
|
Check(sdp == expected, "G.711-only offer byte-exact");
|
|
}
|
|
|
|
// ---- BuildOffer, AMR narrowband only: pt 99, narrowband DTMF only, AS 30
|
|
{
|
|
std::string sdp = BuildOffer({.local = "2001:db8::1", .rtpPort = 50004, .sessionId = 7, .codecs = {"AMR"}});
|
|
Check(sdp.contains("m=audio 50004 RTP/AVP 99 100\r\n"), "AMR-only offer m-line");
|
|
Check(sdp.contains("b=AS:30\r\n"), "AMR-only offer bandwidth");
|
|
Check(sdp.contains("a=rtpmap:99 AMR/8000/1\r\na=fmtp:99 octet-align=1;mode-change-capability=2;max-red=0\r\n"), "AMR-only offer rtpmap+fmtp");
|
|
Check(!sdp.contains("16000"), "no wideband telephone-event without AMR-WB");
|
|
}
|
|
|
|
// ---- BuildOffer, explicit default order == the pinned default bytes
|
|
{
|
|
Offer o{.local = "2001:db8::1", .rtpPort = 50004, .sessionId = 7};
|
|
Offer e = o;
|
|
e.codecs = {"AMR-WB", "AMR"};
|
|
Check(BuildOffer(o) == BuildOffer(e), "explicit AMR-WB,AMR list is byte-identical to the default offer");
|
|
}
|
|
|
|
if (Failures == 0) std::println("Sdp: all tests passed");
|
|
return Failures;
|
|
}
|