Catcrafts/milos-linux
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

reset: warn on reset-gpio release

Browse source 
While we implement an empty .release() callback for reset-gpio (driver
core requires it), this function will never actually be called as nobody
ever removes the device and the last reference is not dropped anywhere.

This is by design - once created, the reset-gpio device stays in memory.
Make the .release() callback emit a warning, should it ever be called
due to a programming bug.

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
This commit is contained in:
Bartosz Golaszewski 2026-03-06 18:22:49 +01:00 • committed by Philipp Zabel
commit 20adbf3b8f
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/reset/core.c
View file

@ -820,7 +820,7 @@ static void __reset_control_put_internal(struct reset_control *rstc)
static void reset_gpio_aux_device_release(struct device *dev)
{
WARN(1, "reset-gpio device %s should never have been removed", dev_name(dev));
}
static int reset_create_gpio_aux_device(struct reset_gpio_lookup *rgpio_dev,