When ttm_tt_swapout() fails, the current code calls
ttm_resource_add_bulk_move() followed by ttm_resource_move_to_lru_tail()
to restore the resource's bulk_move membership.
However, ttm_resource_move_to_lru_tail() places the resource at the tail
of the LRU list which, relative to the walk cursor's hitch node (placed
immediately after the resource when it was yielded), puts the resource
*in front of the* the hitch. The next list_for_each_entry_continue() from
the hitch finds the same resource again, causing an infinite loop.
Fix by deferring del_bulk_move to the success path only.
On the success path, TTM_TT_FLAG_SWAPPED has just been set by
ttm_tt_swapout() but the resource is still tracked in the bulk_move range,
so ttm_resource_del_bulk_move()'s !ttm_resource_unevictable() guard would
incorrectly skip the removal. Introduce
ttm_resource_del_bulk_move_unevictable() which bypasses that guard.
Reported-by: Jatin Kataria <jkataria@netflix.com>
Fixes:
|
||
|---|---|---|
| .. | ||
| ttm_allocation.h | ||
| ttm_backup.h | ||
| ttm_bo.h | ||
| ttm_caching.h | ||
| ttm_device.h | ||
| ttm_execbuf_util.h | ||
| ttm_kmap_iter.h | ||
| ttm_placement.h | ||
| ttm_pool.h | ||
| ttm_range_manager.h | ||
| ttm_resource.h | ||
| ttm_tt.h | ||