Catcrafts/Crafter.LintRules
Watch
2
0
Fork
You've already forked Crafter.LintRules
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: drop the depArgs reference the lite rework left behind

Browse source 
42a2701 removed the depArgs declaration together with the --local
branch it fed, but the GitProject call that remained still passed
.args = depArgs. project.cpp stopped compiling, and with it every load
of this repository: crafter-build's own project.cpp pulls it in through
#pragma crafter dependency, so its build, lint and test runs fail as
soon as the clone is updated.

The call now passes no args. The test's crafter-build dependency only
needs the host defaults, and crafter-build is about to forward a
project's own args to its sibling projects by default anyway. The
comment above it still described the --local checkout the same commit
removed; it now says what the code does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Jorijn van der Graaf 2026-10-31 02:44:46 +01:00
commit 7d93289201
Signed by: jorijnvdgraaf
GPG key ID: 2937E59CDCC1BCFB
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
project.cpp
View file

@ -24,8 +24,7 @@ extern "C" Configuration CrafterBuildProject(std::span<const std::string_view> a
cfg.GetInterfacesAndImplementations(ifaces, impls); cfg.GetInterfacesAndImplementations(ifaces, impls);
// The rule test compiles the module as its own interface and links // The rule test compiles the module as its own interface and links
// crafter-build to run the linter in-process: from git by default, or // crafter-build, from git, to run the linter in-process. Only when this
// the sibling checkout with `crafter-build test --local`. Only when this
// is the project being built: crafter-build itself loads this file as a // is the project being built: crafter-build itself loads this file as a
// dependency, and the test's GitProject would then load crafter-build's // dependency, and the test's GitProject would then load crafter-build's
// project file again and recurse into the cycle guard. No target check: // project file again and recurse into the cycle guard. No target check:
@ -33,7 +32,7 @@ extern "C" Configuration CrafterBuildProject(std::span<const std::string_view> a
// to compare against silently dropped the test on any host that spells // to compare against silently dropped the test on any host that spells
// its triple differently (the Flatpak's x86_64-unknown-linux-gnu). // its triple differently (the Flatpak's x86_64-unknown-linux-gnu).
if (IsTopLevelProject()) { if (IsTopLevelProject()) {
Configuration* build = GitProject({ .source = { .url = "https://forgejo.catcrafts.net/Catcrafts/Crafter.Build.git" }, .args = depArgs }); Configuration* build = GitProject({ .source = { .url = "https://forgejo.catcrafts.net/Catcrafts/Crafter.Build.git" } });
cfg.AddTest("HouseRules", ifaces).Dependencies({ build }); cfg.AddTest("HouseRules", ifaces).Dependencies({ build });
} }
return cfg; return cfg;